Fix Windows installer CreateProcess error and improve macOS blank screen handling

- Fix InnoSetup build error: Replace WizardNotSilent() with not WizardSilent()
- Add ExecutableExists() function to verify executable before launching
- Add build-time verification to check executable exists before creating installer
- Add post-install verification and better error logging
- Improve macOS blank screen fix with async page load event handling
- Add retry logic and multiple fallbacks for window visibility

Author: Tajudeen

build/gulpfile.vscode.win32.js

@@ -75,6 +75,17 @@ function buildWin32Setup(arch, target) {
 		const outputPath = setupDir(arch, target);
 		fs.mkdirSync(outputPath, { recursive: true });
 
+		// CRITICAL: Verify executable exists before creating installer
+		const expectedExePath = path.join(sourcePath, `${product.nameShort}.exe`);
+		if (!fs.existsSync(expectedExePath)) {
+			const errorMsg = `ERROR: Executable not found at expected path: ${expectedExePath}\n` +
+				`This will cause "CreateProcess failed; code 2" error during installation.\n` +
+				`Please verify the Windows build completed successfully and the executable was created.`;
+			console.error(errorMsg);
+			return cb(new Error(errorMsg));
+		}
+		console.log(`✓ Executable verified: ${expectedExePath}`);
+
 		const originalProductJsonPath = path.join(sourcePath, 'resources/app/product.json');
 		const productJsonPath = path.join(outputPath, 'product.json');
 		const productJson = JSON.parse(fs.readFileSync(originalProductJsonPath, 'utf8'));

build/win32/code.iss

@@ -110,8 +110,8 @@ Name: "{userappdata}\Microsoft\Internet Explorer\Quick Launch\{#NameLong}"; File
 ; Automatically install Visual C++ Redistributables if not already installed (silent, no user interaction)
 Filename: "powershell.exe"; Parameters: "-NoLogo -NoProfile -NonInteractive -WindowStyle Hidden -ExecutionPolicy Bypass -Command ""$url='https://aka.ms/vs/17/release/vc_redist.x64.exe'; $out='{tmp}\vc_redist.x64.exe'; if (-not (Test-Path $out)) { [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; Invoke-WebRequest -Uri $url -OutFile $out -UseBasicParsing }; Start-Process -FilePath $out -ArgumentList '/install','/quiet','/norestart' -Wait -NoNewWindow"""; StatusMsg: "Installing Visual C++ Redistributables..."; Check: not IsVCRedistInstalled() and (Arch = "x64"); Flags: runhidden waituntilterminated
 Filename: "powershell.exe"; Parameters: "-NoLogo -NoProfile -NonInteractive -WindowStyle Hidden -ExecutionPolicy Bypass -Command ""$url='https://aka.ms/vs/17/release/vc_redist.arm64.exe'; $out='{tmp}\vc_redist.arm64.exe'; if (-not (Test-Path $out)) { [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; Invoke-WebRequest -Uri $url -OutFile $out -UseBasicParsing }; Start-Process -FilePath $out -ArgumentList '/install','/quiet','/norestart' -Wait -NoNewWindow"""; StatusMsg: "Installing Visual C++ Redistributables..."; Check: not IsVCRedistInstalled() and (Arch = "arm64"); Flags: runhidden waituntilterminated
-Filename: "{app}\{#ExeBasename}.exe"; Description: "{cm:LaunchProgram,{#NameLong}}"; Tasks: runcode; Flags: nowait postinstall; Check: ShouldRunAfterUpdate()
-Filename: "{app}\{#ExeBasename}.exe"; Description: "{cm:LaunchProgram,{#NameLong}}"; Flags: nowait postinstall; Check: WizardNotSilent()
+Filename: "{app}\{#ExeBasename}.exe"; Description: "{cm:LaunchProgram,{#NameLong}}"; Tasks: runcode; Flags: nowait postinstall; Check: ShouldRunAfterUpdate() and ExecutableExists()
+Filename: "{app}\{#ExeBasename}.exe"; Description: "{cm:LaunchProgram,{#NameLong}}"; Flags: nowait postinstall; Check: not WizardSilent() and ExecutableExists()
 
 [Registry]
 #if "user" == InstallTarget
@@ -1458,6 +1458,27 @@ begin
     Result := True;
 end;
 
+// Verify that the executable file exists before trying to launch it
+// This prevents "CreateProcess failed; code 2" errors
+function ExecutableExists(): Boolean;
+var
+  ExePath: String;
+begin
+  ExePath := ExpandConstant('{app}\{#ExeBasename}.exe');
+  Result := FileExists(ExePath);
+  if not Result then
+  begin
+    Log('Warning: Executable not found at: ' + ExePath);
+    // Try alternative locations or wait a bit for file system to sync
+    Sleep(100);
+    Result := FileExists(ExePath);
+    if Result then
+      Log('Executable found after retry')
+    else
+      Log('Executable still not found after retry');
+  end;
+end;
+
 function IsWindows11OrLater(): Boolean;
 begin
   Result := (GetWindowsVersion >= $0A0055F0);
@@ -1556,9 +1577,27 @@ procedure CurStepChanged(CurStep: TSetupStep);
 var
   UpdateResultCode: Integer;
 	StartServiceResultCode: Integer;
+  ExePath: String;
 begin
   if CurStep = ssPostInstall then
   begin
+    // Verify executable exists after installation
+    ExePath := ExpandConstant('{app}\{#ExeBasename}.exe');
+    if not FileExists(ExePath) then
+    begin
+      Log('ERROR: Executable not found after installation at: ' + ExePath);
+      Log('This will cause "CreateProcess failed; code 2" error when trying to launch.');
+      // Try to find the actual executable name
+      // This is a fallback in case the executable has a different name
+      if FileExists(ExpandConstant('{app}\{#ApplicationName}.exe')) then
+        Log('Found alternative executable: {#ApplicationName}.exe')
+      else
+        Log('No alternative executable found either.');
+    end
+    else
+    begin
+      Log('Executable verified at: ' + ExePath);
+    end;
 #ifdef AppxPackageName
     // Remove the old context menu registry keys for insiders
     if QualityIsInsiders() and WizardIsTaskSelected('addcontextmenufiles') then begin

src/vs/platform/windows/electron-main/windowImpl.ts

@@ -1135,8 +1135,9 @@ export class CodeWindow extends BaseWindow implements ICodeWindow {
 		this._win.loadURL(FileAccess.asBrowserUri(`vs/code/electron-browser/workbench/workbench${this.environmentMainService.isBuilt ? '' : '-dev'}.html`).toString(true));
 
 		// Fix for macOS blank screen: Ensure window is visible and has valid bounds
+		// This fix runs immediately and also after the page loads to handle timing issues
 		if (isMacintosh && this._win) {
-			// Force window to be shown if it's not visible
+			// Immediate fix: Force window to be shown if it's not visible
 			if (!this._win.isVisible()) {
 				this._win.showInactive();
 			}
@@ -1151,8 +1152,38 @@ export class CodeWindow extends BaseWindow implements ICodeWindow {
 				this._win.setSize(1024, 768);
 				this._win.center();
 			}
-			// Ensure window is focused to prevent blank screen
-			this._win.focus();
+
+			// Additional fix: Ensure window is visible after page loads (handles async loadURL timing)
+			// Use both 'did-finish-load' and 'dom-ready' events to catch all cases
+			const ensureWindowVisible = () => {
+				if (this._win && !this._win.isDestroyed()) {
+					if (!this._win.isVisible()) {
+						this._win.showInactive();
+					}
+					if (this._win.isMinimized()) {
+						this._win.restore();
+					}
+					// Re-check bounds after page load
+					const currentBounds = this._win.getBounds();
+					if (currentBounds && (currentBounds.width === 0 || currentBounds.height === 0)) {
+						this._win.setSize(1024, 768);
+						this._win.center();
+					}
+					// Ensure window is focused to prevent blank screen
+					this._win.focus();
+				}
+			};
+
+			// Listen for page load events to ensure window is visible
+			this._win.webContents.once('did-finish-load', ensureWindowVisible);
+			this._win.webContents.once('dom-ready', ensureWindowVisible);
+
+			// Also ensure visibility after a short delay as a fallback
+			setTimeout(() => {
+				if (this._win && !this._win.isDestroyed()) {
+					ensureWindowVisible();
+				}
+			}, 100);
 		}
 
 		// Remember that we did load