The Build failure Post to Slack step checks for the previous step's failure instead of the build failure. This is likely not indentional, and also means that the step will never run since the previous step only runs on tag pushes, and the step in question only runs on PRs.
|
- name: Build failure Post to Slack |
|
uses: slackapi/slack-github-action@v2.0.0 |
|
if: ${{ failure() && github.event_name == 'pull_request' }} |
The full fix would have to add the
if: always() conditional to the job iself, and then check
needs.<job_id>.result in the job steps.
The
Build failure Post to Slackstep checks for the previous step's failure instead of the build failure. This is likely not indentional, and also means that the step will never run since the previous step only runs on tag pushes, and the step in question only runs on PRs.optable-ios-sdk/.github/workflows/ios-sdk-ci.yml
Lines 123 to 125 in ca311d9
The full fix would have to add the
if: always()conditional to the job iself, and then checkneeds.<job_id>.resultin the job steps.