Add comprehensive debug logging and memory barriers for macOS CI primitive data bug

This commit addresses the macOS CI-specific primitive data bug where setPrimitiveDataInt() succeeds but doesPrimitiveDataExist() immediately returns false. Research indicates this is likely thread_local storage issues in macOS CI environments.

Author: bnbailey-psl

native/src/pyhelios_wrapper_common.cpp

@@ -4,15 +4,22 @@
 #include "../include/pyhelios_wrapper_common.h"
 #include <string>
 #include <exception>
+#include <cstdio>
 
 // Global error state for thread-safe error handling - matches PyHelios error codes
 static thread_local std::string last_error_message;
 static thread_local int last_error_code = PYHELIOS_SUCCESS;
 
 // Helper function to set error state with PyHelios error codes
 void setError(int error_code, const std::string& message) {
+    // Debug logging for macOS CI thread_local investigation
+    fprintf(stderr, "[DEBUG-THREAD_LOCAL] setError called: code=%d, message=%s\n", error_code, message.c_str());
+    fprintf(stderr, "[DEBUG-THREAD_LOCAL] Previous error state: code=%d\n", last_error_code);
+
     last_error_code = error_code;
     last_error_message = message;
+
+    fprintf(stderr, "[DEBUG-THREAD_LOCAL] Error state updated: code=%d\n", last_error_code);
 }
 
 extern "C" {
@@ -22,6 +29,7 @@ extern "C" {
     //=============================================================================
 
     int getLastErrorCode() {
+        fprintf(stderr, "[DEBUG-THREAD_LOCAL] getLastErrorCode() returning: %d\n", last_error_code);
         return last_error_code;
     }
 
@@ -30,8 +38,10 @@ extern "C" {
     }
 
     void clearError() {
+        fprintf(stderr, "[DEBUG-THREAD_LOCAL] clearError() called, previous code: %d\n", last_error_code);
         last_error_code = PYHELIOS_SUCCESS;
         last_error_message.clear();
+        fprintf(stderr, "[DEBUG-THREAD_LOCAL] clearError() completed, new code: %d\n", last_error_code);
     }
 
 } //extern "C"

native/src/pyhelios_wrapper_context.cpp

@@ -7,6 +7,8 @@
 #include <string>
 #include <exception>
 #include <cstring>
+#include <cstdio>
+#include <atomic>
 
 extern "C" {
     // Context management - core functionality required by PyHelios
@@ -1476,21 +1478,43 @@ extern "C" {
     void setPrimitiveDataInt(helios::Context* context, unsigned int uuid, const char* label, int value) {
         // Clear error state before any operation to prevent contamination from previous calls
         clearError();
+
+        // Debug logging for macOS CI investigation
+        fprintf(stderr, "[DEBUG-MACOS] setPrimitiveDataInt: uuid=%u, label=%s, value=%d\n", uuid, label, value);
+        fprintf(stderr, "[DEBUG-MACOS] Initial error state: code=%d\n", getLastErrorCode());
+
         try {
             if (!context) {
                 setError(PYHELIOS_ERROR_INVALID_PARAMETER, "Context pointer is null");
+                fprintf(stderr, "[DEBUG-MACOS] ERROR: Context pointer is null\n");
                 return;
             }
             if (!label) {
                 setError(PYHELIOS_ERROR_INVALID_PARAMETER, "Label is null");
+                fprintf(stderr, "[DEBUG-MACOS] ERROR: Label is null\n");
                 return;
             }
+
+            fprintf(stderr, "[DEBUG-MACOS] About to call context->setPrimitiveData()\n");
             context->setPrimitiveData(uuid, label, value);
+
+            // Memory barrier to ensure data write completion before verification
+            std::atomic_thread_fence(std::memory_order_seq_cst);
+            fprintf(stderr, "[DEBUG-MACOS] context->setPrimitiveData() completed successfully with memory barrier\n");
+
+            // Immediate verification to debug thread_local storage issue
+            bool exists_immediately = context->doesPrimitiveDataExist(uuid, label);
+            fprintf(stderr, "[DEBUG-MACOS] Immediate verification: exists=%s\n", exists_immediately ? "true" : "false");
+
         } catch (const std::exception& e) {
             setError(PYHELIOS_ERROR_RUNTIME, std::string("ERROR (Context::setPrimitiveData): ") + e.what());
+            fprintf(stderr, "[DEBUG-MACOS] Exception caught: %s\n", e.what());
         } catch (...) {
             setError(PYHELIOS_ERROR_UNKNOWN, "ERROR (Context::setPrimitiveData): Unknown error setting primitive data int.");
+            fprintf(stderr, "[DEBUG-MACOS] Unknown exception caught\n");
         }
+
+        fprintf(stderr, "[DEBUG-MACOS] Final error state: code=%d\n", getLastErrorCode());
     }
 
     void setPrimitiveDataString(helios::Context* context, unsigned int uuid, const char* label, const char* value) {
@@ -1595,23 +1619,42 @@ extern "C" {
     bool doesPrimitiveDataExist(helios::Context* context, unsigned int uuid, const char* label) {
         // Clear error state before any operation to prevent contamination from previous calls
         clearError();
+
+        // Debug logging for macOS CI investigation
+        fprintf(stderr, "[DEBUG-MACOS] doesPrimitiveDataExist: uuid=%u, label=%s\n", uuid, label);
+        fprintf(stderr, "[DEBUG-MACOS] Initial error state: code=%d\n", getLastErrorCode());
+
         try {
             if (!context) {
                 setError(PYHELIOS_ERROR_INVALID_PARAMETER, "Context pointer is null");
+                fprintf(stderr, "[DEBUG-MACOS] ERROR: Context pointer is null\n");
                 return false;
             }
             if (!label) {
                 setError(PYHELIOS_ERROR_INVALID_PARAMETER, "Label is null");
+                fprintf(stderr, "[DEBUG-MACOS] ERROR: Label is null\n");
                 return false;
             }
-            return context->doesPrimitiveDataExist(uuid, label);
+
+            fprintf(stderr, "[DEBUG-MACOS] About to call context->doesPrimitiveDataExist()\n");
+
+            // Memory barrier to ensure any pending writes are visible before reading
+            std::atomic_thread_fence(std::memory_order_acquire);
+            bool result = context->doesPrimitiveDataExist(uuid, label);
+            fprintf(stderr, "[DEBUG-MACOS] context->doesPrimitiveDataExist() returned: %s (with memory barrier)\n", result ? "true" : "false");
+
+            return result;
         } catch (const std::exception& e) {
             setError(PYHELIOS_ERROR_RUNTIME, std::string("ERROR (Context::doesPrimitiveDataExist): ") + e.what());
+            fprintf(stderr, "[DEBUG-MACOS] Exception caught: %s\n", e.what());
             return false;
         } catch (...) {
             setError(PYHELIOS_ERROR_UNKNOWN, "ERROR (Context::doesPrimitiveDataExist): Unknown error checking primitive data existence.");
+            fprintf(stderr, "[DEBUG-MACOS] Unknown exception caught\n");
             return false;
         }
+
+        fprintf(stderr, "[DEBUG-MACOS] Final error state: code=%d\n", getLastErrorCode());
     }
 
     void setPrimitiveDataVec3(helios::Context* context, unsigned int uuid, const char* label, float x, float y, float z) {