Skip to content

app-header-layout should respect header's scrollTarget #547

@bennypowers

Description

@bennypowers

Description

<app-header-layout> clobbers it's header's scrollTarget in _updateLayoutStates

Expected outcome

If scrollTarget is set on header, it should be respected

Actual outcome

scrollTarget is reset to either documentElement or contentContainer

Live Demo

https://jsbin.com/wusagubagi/1/edit?html,js,console

Steps to reproduce

  1. Put a app-header-layout element in the page with an app-header.
  • set the app-header scrollTarget property.
  • scrollTarget is reset by app-header-layout.

Browsers Affected

  • Chrome
  • [ x] Firefox
  • [ x] Safari 9
  • [ x] Safari 8
  • [x ] Safari 7
  • [x ] Edge
  • [x ] IE 11
  • [x ] IE 10

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions