fix: Fix Enter key blocked after dismissing empty suggestion popup (#1471)

## Problem

Pressing Escape on a suggestion popup with no results hides it visually but leaves the Tippy DOM node mounted, causing the Enter-to-submit handler to think a suggestion is still active.

<!-- Who is this for and what problem does it solve? -->

<!-- Closes #ISSUE_ID -->

## Changes

1. Track dismissed flag in CommandMention and FileMention suggestion renderers
2. Return false from onKeyDown when dismissed so Enter propagates normally
3. Return false from SuggestionList when no item is selected instead of swallowing the event
4. Check for visible Tippy box (data-state not hidden) instead of just DOM presence
5. Reset dismissed flag when new non-empty suggestions arrive

<!-- What did you change and why? -->

<!-- If there are frontend changes, include screenshots. -->

## How did you test this?

Manually

<!-- Describe what you tested -- manual steps, automated tests, or both. -->

<!-- If you're an agent, only list tests you actually ran. -->

Author: charlesvien

apps/code/src/renderer/features/message-editor/tiptap/CommandMention.ts

@@ -23,9 +23,11 @@ function createSuggestion(
     render: () => {
       let component: ReactRenderer<SuggestionListRef> | null = null;
       let popup: TippyInstance | null = null;
+      let dismissed = false;
 
       return {
         onStart: (props) => {
+          dismissed = false;
           component = new ReactRenderer(SuggestionList, {
             props: {
               items: props.items,
@@ -51,6 +53,7 @@ function createSuggestion(
         },
 
         onUpdate: (props) => {
+          if (props.items.length > 0) dismissed = false;
           component?.updateProps({
             items: props.items,
             command: props.command,
@@ -67,9 +70,12 @@ function createSuggestion(
           if (props.event.key === "Escape") {
             props.event.stopPropagation();
             popup?.hide();
+            dismissed = true;
             return true;
           }
 
+          if (dismissed) return false;
+
           return component?.ref?.onKeyDown(props) ?? false;
         },
 

apps/code/src/renderer/features/message-editor/tiptap/FileMention.ts

@@ -27,9 +27,11 @@ function createSuggestion(
     render: () => {
       let component: ReactRenderer<SuggestionListRef> | null = null;
       let popup: TippyInstance | null = null;
+      let dismissed = false;
 
       return {
         onStart: (props) => {
+          dismissed = false;
           const items = props.items.length > 0 ? props.items : lastItems;
           component = new ReactRenderer(SuggestionList, {
             props: {
@@ -56,6 +58,7 @@ function createSuggestion(
         },
 
         onUpdate: (props) => {
+          if (props.items.length > 0) dismissed = false;
           const items = props.items.length > 0 ? props.items : lastItems;
           component?.updateProps({
             items,
@@ -73,9 +76,12 @@ function createSuggestion(
           if (props.event.key === "Escape") {
             props.event.stopPropagation();
             popup?.hide();
+            dismissed = true;
             return true;
           }
 
+          if (dismissed) return false;
+
           return component?.ref?.onKeyDown(props) ?? false;
         },
 

apps/code/src/renderer/features/message-editor/tiptap/SuggestionList.tsx

@@ -57,8 +57,11 @@ export const SuggestionList = forwardRef<
         return true;
       }
       if (event.key === "Enter" || event.key === "Tab") {
-        if (items[selectedIndex]) command(items[selectedIndex]);
-        return true;
+        if (items[selectedIndex]) {
+          command(items[selectedIndex]);
+          return true;
+        }
+        return false;
       }
       return false;
     },

apps/code/src/renderer/features/message-editor/tiptap/useTiptapEditor.ts

@@ -187,9 +187,11 @@ export function useTiptapEditor(options: UseTiptapEditorOptions) {
 
             if (isSubmitKey) {
               if (!view.editable || submitDisabledRef.current) return false;
-              const suggestionPopup =
-                document.querySelector("[data-tippy-root]");
-              if (suggestionPopup) return false;
+              // tippy.js sets data-state="hidden" when hiding via .hide()
+              const visibleSuggestion = document.querySelector(
+                "[data-tippy-root] .tippy-box:not([data-state='hidden'])",
+              );
+              if (visibleSuggestion) return false;
               event.preventDefault();
               historyActions.reset();
               submitRef.current();