feat: add branded custom 404 page in App Router#1010
Conversation
|
@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
The DashboardHeader renders the h1 as 'DASHBOARD' (all-caps via
design), but the Playwright selectors used an exact-case match
{ name: "Dashboard" } which never matched.
Changed all three heading assertions to /dashboard/i regex so they
match the actual DOM output and unblock every failing E2E test.
landing.spec.js: - Remove assertion for 'DevTrack' h1 (hero reads 'YOUR CODE HAS A PULSE') - Add .first() to 'Sign in with GitHub' link selectors (2 links on page, strict mode violation) - Replace 'View on GitHub' link with '★ Star on GitHub' (actual text) auth-bypass.spec.js: - Add .first() to 'Sign in with GitHub' link (strict mode violation) - Change heading assertions from exact 'Dashboard' to /dashboard/i regex dashboard-widgets.spec.js: - Add mock for /api/goals/sync so GoalTracker doesn't hang waiting for a real Supabase call (Goals heading was never rendering in CI) - Add mocks for additional API routes hit on dashboard load
|
Hi! This PR now has a merge conflict with main, likely on the shared e2e test files ( git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-leaseYour actual feature/fix changes are valuable — we'd love to get this merged once rebased! |
Closes #971.
Summary of What Has Been Done:
Created a custom branded 404 page in the Next.js App Router for DevTrack.
Changes Made:
src/app/not-found.tsxwith professional typography, rotated badge visual effects, and customized styles matching DevTrack theme system.