test: add unit tests for safeCompare timing-safe comparison#1015
test: add unit tests for safeCompare timing-safe comparison#1015Sarthak-Nayak wants to merge 1 commit into
Conversation
|
@Sarthak-Nayak is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!
|
Hi! This PR now has a merge conflict with main, likely on the shared e2e test files ( git fetch origin
git rebase origin/main
# resolve any conflicts
git push --force-with-leaseYour actual feature/fix changes are valuable — we'd love to get this merged once rebased! |
Closes #827
Summary of Changes:
safeComparefromsrc/app/api/webhooks/github/route.tsto make it accessible for the test runner.falsereturns on length mismatch (beforetimingSafeEqual).trueevaluations on identical strings.crypto.timingSafeEqualto actively verify that the timing-safe comparison logic is triggered appropriately.