Fix simulation actions not updating during server runtime

Sim actions (enable/disable/delete/add/modify) now take effect immediately
without restarting the server. The runtime task listens to project signals
and rebuilds its action list dynamically, with mutex-protected thread safety.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: QuakeString

src/server/runtime/server_runsimactiontask.cpp

@@ -26,20 +26,35 @@
 
 #include "server_runsimaction.h"
 
+#include <project/server_project.h>
 #include <project/server_simaction.h>
 
-mbServerRunSimActionTask::mbServerRunSimActionTask(QObject *parent) : mbCoreTask(parent)
+mbServerRunSimActionTask::mbServerRunSimActionTask(mbServerProject *project, QObject *parent) : mbCoreTask(parent)
 {
+    m_project = project;
+    m_dirty = false;
+
+    connect(m_project, &mbServerProject::simActionAdded,    this, &mbServerRunSimActionTask::rebuildActions);
+    connect(m_project, &mbServerProject::simActionRemoved,  this, &mbServerRunSimActionTask::rebuildActions);
+    connect(m_project, &mbServerProject::simActionChanged,  this, &mbServerRunSimActionTask::rebuildActions);
 }
 
 mbServerRunSimActionTask::~mbServerRunSimActionTask()
 {
-    qDeleteAll(m_actions);
+    clearActions();
+}
+
+void mbServerRunSimActionTask::rebuildActions()
+{
+    QMutexLocker locker(&m_mutex);
+    m_dirty = true;
 }
 
-void mbServerRunSimActionTask::setActions(const QList<mbServerSimAction *> &actions)
+void mbServerRunSimActionTask::buildActions()
 {
-    Q_FOREACH(mbServerSimAction *i, actions)
+    clearActions();
+    const QList<mbServerSimAction*> &actions = m_project->simActions();
+    for (mbServerSimAction *i : actions)
     {
         if (!i->device())
             continue;
@@ -62,30 +77,55 @@ void mbServerRunSimActionTask::setActions(const QList<mbServerSimAction *> &acti
             break;
         }
         if (item)
-            m_actions.append(item);
+        {
+            ActionEntry entry;
+            entry.source = i;
+            entry.runtime = item;
+            m_actions.append(entry);
+        }
     }
+    // Initialize newly built actions
+    qint64 time = QDateTime::currentMSecsSinceEpoch();
+    for (const ActionEntry &e : m_actions)
+        e.runtime->init(time);
+}
+
+void mbServerRunSimActionTask::clearActions()
+{
+    for (const ActionEntry &e : m_actions)
+        delete e.runtime;
+    m_actions.clear();
 }
 
 int mbServerRunSimActionTask::init()
 {
-    qint64 time = QDateTime::currentMSecsSinceEpoch();
-    Q_FOREACH(mbServerRunSimAction *i, m_actions)
-        i->init(time);
+    QMutexLocker locker(&m_mutex);
+    buildActions();
     return 0;
 }
 
 int mbServerRunSimActionTask::loop()
 {
+    QMutexLocker locker(&m_mutex);
+    if (m_dirty)
+    {
+        buildActions();
+        m_dirty = false;
+    }
     qint64 time = QDateTime::currentMSecsSinceEpoch();
-    Q_FOREACH(mbServerRunSimAction *i, m_actions)
-        i->exec(time);
+    for (const ActionEntry &e : m_actions)
+    {
+        if (e.source->isEnabled())
+            e.runtime->exec(time);
+    }
     return 0;
 }
 
 int mbServerRunSimActionTask::final()
 {
+    QMutexLocker locker(&m_mutex);
     qint64 time = QDateTime::currentMSecsSinceEpoch();
-    Q_FOREACH(mbServerRunSimAction *i, m_actions)
-        i->final(time);
+    for (const ActionEntry &e : m_actions)
+        e.runtime->final(time);
     return 0;
 }

src/server/runtime/server_runsimactiontask.h

@@ -23,29 +23,45 @@
 #ifndef SERVER_RUNSIMACTIONTASK_H
 #define SERVER_RUNSIMACTIONTASK_H
 
+#include <QMutex>
+
 #include <mbcore_task.h>
 
+class mbServerProject;
 class mbServerSimAction;
 class mbServerRunSimAction;
 
 class mbServerRunSimActionTask : public mbCoreTask
 {
-public:
-    explicit mbServerRunSimActionTask(QObject *parent = nullptr);
-    ~mbServerRunSimActionTask();
+    Q_OBJECT
 
 public:
-    void setActions(const QList<mbServerSimAction*> &actions);
+    explicit mbServerRunSimActionTask(mbServerProject *project, QObject *parent = nullptr);
+    ~mbServerRunSimActionTask();
 
 public: // task interface
     virtual int init() override;
     virtual int loop() override;
     virtual int final() override;
 
+private Q_SLOTS:
+    void rebuildActions();
+
+private:
+    void buildActions();
+    void clearActions();
+
 private:
-    typedef QList<mbServerRunSimAction*> Actions_t;
+    struct ActionEntry
+    {
+        mbServerSimAction    *source;  // project-level (for enabled check)
+        mbServerRunSimAction *runtime; // execution object
+    };
 
-    Actions_t m_actions;
+    mbServerProject *m_project;
+    QMutex m_mutex;
+    QList<ActionEntry> m_actions;
+    bool m_dirty;
 };
 
 #endif // SERVER_RUNSIMACTIONTASK_H

src/server/runtime/server_runtime.cpp

@@ -54,8 +54,7 @@ void mbServerRuntime::createComponents()
 {
     mbCoreRuntime::createComponents();
 
-    mbServerRunSimActionTask *simActionTask = new mbServerRunSimActionTask;
-    simActionTask->setActions(project()->simActions());
+    mbServerRunSimActionTask *simActionTask = new mbServerRunSimActionTask(project());
     mbCoreRunTaskThread *simActionThread = new mbCoreRunTaskThread(simActionTask);
     m_taskThreads.append(simActionThread);