`time[len]` cannot be handle properly when as param

[dcaoyuan]

Test case:

//@version=6
indicator("time as param", overlay=true)

var ph_times = array.new_float(0)
array.unshift(ph_times, time[15])

Here, array.param(time, 15, 'p1')` will got 'NaN'

We may need time to be CONTEXT_DATA_VARS, just like bar_index.
Since we already have openTime, just need alias time to openTime.

[dcaoyuan]

time is complex, in form of time, time(...) and time[...] :D

[alaa-eddine]

there are many namespaces in Pine Script like this (Pine Script is very special 😄 )

but I have patterns to handle all these cases, I'll tackle missing time features soon.

if you are curious I have described different approaches that are used in PineTS to handle these Pine Script special cases here : https://github.com/QuantForgeOrg/PineTS/blob/main/src/namespaces/README.md

[dcaoyuan]

I got a solution for this issue, please see my fixing commit.

[alaa-eddine]

I think that the fix works but it's addressing the problem late (after a series is used as a nested series).
I suspect that this could break some other scenarios => need to check

also can you confirm that the problem you are facing here is that the array (ph_times) is not getting the right value from time[15] ?

[dcaoyuan]

Let's see the test case when time[15] is used as param:

var pl_times = array.new_int(0)
array.unshift(pl_times, time[15])

We'll get the toJS code like:

(async $ => {
  const {array, time} = $.pine;
  const p0 = array.param(0, undefined, 'p0');
  const temp_1 = array.new_int(p0);
  $.var.glb1_pl_times = $.initVar($.var.glb1_pl_times, temp_1);
  const p1 = array.param($.var.glb1_pl_times, undefined, 'p1');
  const p2 = array.param(time, 15, 'p2');
  const temp_2 = array.unshift(p1, p2);
  temp_2;
});

We have:

const p2 = array.param(time, 15, 'p2');

We'll reach:

PineTS/src/namespaces/array/methods/param.ts

Lines 5 to 9 in ad26f8d

	export function param(context: any) {
	return (source: any, index: number = 0) => {
	return Series.from(source).get(index);
	};
	}

)

Where param source in Series.from(source).get(index) will be time which is the instance of TimeHelper that we injected in Context.

PineTS/src/Context.class.ts

Lines 149 to 155 in ad26f8d

	fixnan: core.fixnan.bind(core),
	alertcondition: core.alertcondition.bind(core),
	timestamp: core.timestamp.bind(core),
	time: new TimeHelper(this, 'openTime'),
	time_close: new TimeHelper(this, 'closeTime'),
	dayofmonth: new TimeComponentHelper(this, EXTRACTORS.dayofmonth),
	dayofweek: new TimeComponentHelper(this, EXTRACTORS.dayofweek),

We finally get:

Series.from(time: TimeHelper).get(15); 

Which will fail.

My fix is trying to treat time:TimeHelper as a Series, thus could be called as Series.from(convertedTime).get(15);

I think this fix is a natural extended usage of the special '__value' property you defined:
https://github.com/QuantForgeOrg/PineTS/blob/main/src/namespaces/README.md#case-6-dual-use-identifiers-variable--function