From 9b4a3bf434aa951cb0ee6df916acabe112277257 Mon Sep 17 00:00:00 2001 From: Tasso Evangelista Date: Tue, 2 Jun 2026 22:46:32 -0300 Subject: [PATCH] refactor: remove unnecessary ReactElement type annotations from components --- .../ui-message/client/messageBox/createComposerAPI.ts | 2 +- apps/meteor/client/lib/chats/ChatAPI.ts | 2 +- apps/meteor/tests/mocks/client/FakeChatProvider.tsx | 4 ++-- apps/meteor/tests/mocks/client/FakeRoomProvider.tsx | 4 ++-- apps/meteor/tests/mocks/client/ModalContextMock.tsx | 4 ++-- apps/meteor/tests/mocks/client/RouterContextMock.tsx | 10 ++-------- 6 files changed, 10 insertions(+), 16 deletions(-) diff --git a/apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts b/apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts index 04447635ad45e..2018abfa5fa91 100644 --- a/apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts +++ b/apps/meteor/app/ui-message/client/messageBox/createComposerAPI.ts @@ -15,7 +15,7 @@ export const createComposerAPI = ( persistDraft: (value: string) => void, initialDraft: string, quoteChainLimit: number, - composerRef: RefObject, + composerRef: RefObject, { rid, tmid }: { rid: string; tmid?: string }, ): ComposerAPI => { const triggerEvent = (input: HTMLTextAreaElement, evt: string): void => { diff --git a/apps/meteor/client/lib/chats/ChatAPI.ts b/apps/meteor/client/lib/chats/ChatAPI.ts index db2e61ad640af..2826f3f56de58 100644 --- a/apps/meteor/client/lib/chats/ChatAPI.ts +++ b/apps/meteor/client/lib/chats/ChatAPI.ts @@ -68,7 +68,7 @@ export type ComposerAPI = { readonly formatters: Subscribable; - readonly composerRef: RefObject; + readonly composerRef: RefObject; readonly uploads: UploadsAPI; }; diff --git a/apps/meteor/tests/mocks/client/FakeChatProvider.tsx b/apps/meteor/tests/mocks/client/FakeChatProvider.tsx index a71e49df666e8..1243f38b1ce36 100644 --- a/apps/meteor/tests/mocks/client/FakeChatProvider.tsx +++ b/apps/meteor/tests/mocks/client/FakeChatProvider.tsx @@ -1,4 +1,4 @@ -import type { ReactElement, ReactNode } from 'react'; +import type { ReactNode } from 'react'; import { ChatContext } from '../../../client/views/room/contexts/ChatContext'; import { createFakeSubscription } from '../data'; @@ -7,7 +7,7 @@ type FakeChatProviderProps = { children?: ReactNode; }; -const FakeChatProvider = ({ children }: FakeChatProviderProps): ReactElement => { +const FakeChatProvider = ({ children }: FakeChatProviderProps) => { return ( ; }; -const FakeRoomProvider = ({ children, roomOverrides, subscriptionOverrides }: FakeRoomProviderProps): ReactElement => { +const FakeRoomProvider = ({ children, roomOverrides, subscriptionOverrides }: FakeRoomProviderProps) => { return ( { diff --git a/apps/meteor/tests/mocks/client/ModalContextMock.tsx b/apps/meteor/tests/mocks/client/ModalContextMock.tsx index 07d97156b1ac5..7f3636c89aff5 100644 --- a/apps/meteor/tests/mocks/client/ModalContextMock.tsx +++ b/apps/meteor/tests/mocks/client/ModalContextMock.tsx @@ -1,12 +1,12 @@ import { ModalContext } from '@rocket.chat/ui-contexts'; -import type { ReactElement, ContextType, ReactNode } from 'react'; +import type { ContextType, ReactNode } from 'react'; import { useMemo } from 'react'; type ModalContextMockProps = { children: ReactNode; }; -const ModalContextMock = ({ children }: ModalContextMockProps): ReactElement => { +const ModalContextMock = ({ children }: ModalContextMockProps) => { const value = useMemo( () => ({ modal: { diff --git a/apps/meteor/tests/mocks/client/RouterContextMock.tsx b/apps/meteor/tests/mocks/client/RouterContextMock.tsx index 7a511289f7d02..53eb6c84b1283 100644 --- a/apps/meteor/tests/mocks/client/RouterContextMock.tsx +++ b/apps/meteor/tests/mocks/client/RouterContextMock.tsx @@ -2,7 +2,7 @@ import type { To, SearchParameters, LocationPathname, LocationSearch } from '@ro import { RouterContext } from '@rocket.chat/ui-contexts'; import { compile } from 'path-to-regexp'; import { useRef, useMemo } from 'react'; -import type { MutableRefObject, ReactElement, ReactNode } from 'react'; +import type { MutableRefObject, ReactNode } from 'react'; const encodeSearchParameters = (searchParameters: SearchParameters) => { const search = new URLSearchParams(); @@ -63,13 +63,7 @@ type RouterContextMockProps = { routeParameters?: Record; }; -const RouterContextMock = ({ - children, - navigate, - currentPath, - searchParameters = {}, - routeParameters = {}, -}: RouterContextMockProps): ReactElement => { +const RouterContextMock = ({ children, navigate, currentPath, searchParameters = {}, routeParameters = {} }: RouterContextMockProps) => { const history = useRef<{ stack: To[]; index: number }>({ stack: ['/'], index: 0 }); if (currentPath) {