From fec8454266d304f5bf6b60f5b25ac5f3144c89ba Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 11 Mar 2026 16:31:43 +0000 Subject: [PATCH 1/3] Initial plan From 79d3d4bc22e61835f3f784f9819c28c0711b1e7f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 11 Mar 2026 16:34:17 +0000 Subject: [PATCH 2/3] Apply PR review feedback: frozen string literals, Rails guard, file handle fix Co-authored-by: OutlawAndy <1504753+OutlawAndy@users.noreply.github.com> --- lib/generators/rolemodel/base_generator.rb | 2 ++ lib/rolemodel-rails.rb | 10 +++++++++- spec/spec_helper.rb | 2 ++ spec/support/helpers/example_app.rb | 3 +-- 4 files changed, 14 insertions(+), 3 deletions(-) diff --git a/lib/generators/rolemodel/base_generator.rb b/lib/generators/rolemodel/base_generator.rb index 08898ccb..ebfe333d 100644 --- a/lib/generators/rolemodel/base_generator.rb +++ b/lib/generators/rolemodel/base_generator.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'rails/generators/base' require 'rails/generators/bundle_helper' require_relative 'replace_content_helper' diff --git a/lib/rolemodel-rails.rb b/lib/rolemodel-rails.rb index fd394225..8e8cf16c 100644 --- a/lib/rolemodel-rails.rb +++ b/lib/rolemodel-rails.rb @@ -1,7 +1,15 @@ +# frozen_string_literal: true + module Rolemodel NODE_VERSION = '24.12.0' RUBY_VERSION = '4.0.1' end require 'rolemodel/version' -require 'rolemodel/engine' + +begin + require 'rails/engine' +rescue LoadError +end + +require 'rolemodel/engine' if defined?(Rails::Engine) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index d46b9c83..56d7e19f 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'rails' require 'bundler/setup' require 'generator_spec' diff --git a/spec/support/helpers/example_app.rb b/spec/support/helpers/example_app.rb index 10f7ab6f..99a9dd26 100644 --- a/spec/support/helpers/example_app.rb +++ b/spec/support/helpers/example_app.rb @@ -26,8 +26,7 @@ def cleanup_test_app def clean_test_gemfile gemfile_path = File.join(destination_root, 'Gemfile') - gemfile = File.open(gemfile_path) - File.write(gemfile_path, gemfile.grep_v(/rolemodel-rails/).join) + File.write(gemfile_path, File.readlines(gemfile_path).grep_v(/rolemodel-rails/).join) end end From da3f9fa22b792fb33a02d76d88a6225dff3b5271 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 11 Mar 2026 16:39:34 +0000 Subject: [PATCH 3/3] Revert Rails engine guard, keep frozen_string_literal in rolemodel-rails.rb Co-authored-by: OutlawAndy <1504753+OutlawAndy@users.noreply.github.com> --- lib/rolemodel-rails.rb | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/rolemodel-rails.rb b/lib/rolemodel-rails.rb index 8e8cf16c..d6ccc1df 100644 --- a/lib/rolemodel-rails.rb +++ b/lib/rolemodel-rails.rb @@ -6,10 +6,4 @@ module Rolemodel end require 'rolemodel/version' - -begin - require 'rails/engine' -rescue LoadError -end - -require 'rolemodel/engine' if defined?(Rails::Engine) +require 'rolemodel/engine'