Skip to content

Commit 859cf0b

Browse files
fix(ci): remove redundant std::move in StreamingSink::create return
GCC -Wredundant-move with -Werror fails CI on Ubuntu 24.04. NRVO handles the move automatically; explicit std::move is unnecessary.
1 parent c6a3ba2 commit 859cf0b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

include/signet/ai/streaming_sink.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ class StreamingSink {
474474
const bool auto_start = impl->opts_.auto_start;
475475
StreamingSink sink(std::move(impl));
476476
if (auto_start) sink.impl_->start();
477-
return std::move(sink); // StreamingSink is movable (unique_ptr<Impl>)
477+
return sink; // NRVO — std::move is redundant here (GCC -Wredundant-move)
478478
}
479479

480480
// -------------------------------------------------------------------------

0 commit comments

Comments
 (0)