further log refactoring

Author: thefringeninja

src/SqlStreamStore.Server/SqlStreamStoreFactory.cs

@@ -41,20 +41,7 @@ public IStreamStore Create()
             }
         }
 
-        public InMemoryStreamStore CreateInMemoryStreamStore()
-        {
-            if (_configuration.Schema != default)
-            {
-                LogNotSupported(mysql, nameof(_configuration.Schema));
-            }
-
-            if (_configuration.DisableDeletionTracking)
-            {
-                LogNotSupported(mysql, nameof(_configuration.DisableDeletionTracking));
-            }
-
-            return new InMemoryStreamStore();
-        }
+        public InMemoryStreamStore CreateInMemoryStreamStore() => new InMemoryStreamStore();
 
         public MsSqlStreamStoreV3 CreateMsSqlStreamStore()
         {
@@ -72,17 +59,10 @@ public MsSqlStreamStoreV3 CreateMsSqlStreamStore()
         }
 
         public MySqlStreamStore CreateMySqlStreamStore()
-        {
-            if (_configuration.Schema != default)
-            {
-                LogNotSupported(mysql, nameof(_configuration.Schema));
-            }
-
-            return new MySqlStreamStore(new MySqlStreamStoreSettings(_configuration.ConnectionString)
+            => new MySqlStreamStore(new MySqlStreamStoreSettings(_configuration.ConnectionString)
             {
                 DisableDeletionTracking = _configuration.DisableDeletionTracking
             });
-        }
 
         public PostgresStreamStore CreatePostgresStreamStore()
         {
@@ -98,11 +78,5 @@ public PostgresStreamStore CreatePostgresStreamStore()
 
             return new PostgresStreamStore(settings);
         }
-
-        private static void LogNotSupported(string provider, string configurationKey) =>
-            s_Log.Warning(
-                "Configuration key '{configurationKey}' is not supported for provider {provider}. It will be ignored.",
-                configurationKey,
-                provider);
     }
 }

src/SqlStreamStore.Server/SqlStreamStoreServer.cs

@@ -6,6 +6,7 @@
 using Serilog;
 using Serilog.Events;
 using SqlStreamStore.HAL;
+using static SqlStreamStore.Server.Constants;
 
 namespace SqlStreamStore.Server
 {
@@ -42,6 +43,34 @@ private SqlStreamStoreServer(SqlStreamStoreServerConfiguration configuration)
 
             s_Log.Information(configuration.ToString());
 
+            switch (configuration.Provider)
+            {
+                case inmemory:
+                    if (configuration.ConnectionString != default)
+                    {
+                        ConfigurationNotSupported(inmemory, nameof(_configuration.ConnectionString));
+                    }
+
+                    if (configuration.Schema != default)
+                    {
+                        ConfigurationNotSupported(inmemory, nameof(_configuration.Schema));
+                    }
+
+                    if (configuration.DisableDeletionTracking)
+                    {
+                        ConfigurationNotSupported(inmemory, nameof(_configuration.DisableDeletionTracking));
+                    }
+
+                    break;
+                case mysql:
+                    if (configuration.Schema != default)
+                    {
+                        ConfigurationNotSupported(mysql, nameof(_configuration.Schema));
+                    }
+
+                    break;
+            }
+
             _configuration = configuration;
             _cts = new CancellationTokenSource();
             _factory = new SqlStreamStoreFactory(configuration);
@@ -105,6 +134,12 @@ private Task RunInitialization()
         private Task RunDatabaseInitialization()
             => new DatabaseInitializer(_configuration).Initialize(_cts.Token);
 
+        private static void ConfigurationNotSupported(string provider, string configurationKey) =>
+            s_Log.Warning(
+                "Configuration key '{configurationKey}' is not supported for provider {provider}. It will be ignored.",
+                configurationKey,
+                provider);
+
         public void Dispose()
         {
             _cts?.Dispose();