Add LogExpFunctions 1.0 to compat#76
Merged
ChrisRackauckas merged 1 commit intoMay 28, 2026
Merged
Conversation
LogExpFunctions v1.0.0's only listed breaking change is a docstring relaxation for log2mexp, which PoissonRandom does not use. The only LogExpFunctions API consumed here is log1pmx (src/PoissonRandom.jl:114), whose v1.0 release added a Float32 implementation and improved accuracy but kept the signature unchanged. Full test suite (Aqua, JET, ExplicitImports, statistical samplers, BigFloat support, PassthroughRNG dispatch, AllocCheck) passes against LogExpFunctions 1.0.0 on Julia 1.10, 1.11, and 1.12. This is the same change as dependabot PR SciML#75; opening it as a regular PR for review. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Contributor
Author
|
CI status on this PR:
Note: the matching dependabot PR (#75) shows all test jobs failing, which is not caused by the LogExpFunctions bump. It's the In other words, #75 fails for unrelated CI-config reasons, not because LogExpFunctions 1.0 is broken. The compat widening itself is safe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Supersedes #75 (dependabot). This is the same compat bump (
LogExpFunctions = "0.3, 1.0") plus a verification record.Summary
LogExpFunctions v1.0.0's only listed breaking change is a docstring relaxation for
log2mexp(JuliaStats/LogExpFunctions.jl#103). PoissonRandom does not uselog2mexp.The only LogExpFunctions API consumed here is
log1pmxatsrc/PoissonRandom.jl:114. The v1.0 release added aFloat32implementation and improved accuracy forlog1pmx, but the signature and behavior on existing inputs are unchanged. No code changes are required — only the compat bound.Verification
Ran the full test suite (Aqua, JET static analysis, ExplicitImports, count_rand/ad_rand/pois_rand statistical samplers, BigFloat support, PassthroughRNG dispatch, AllocCheck zero-allocation tests) against LogExpFunctions 1.0.0 on:
Also spot-checked
log1pmxdirectly withFloat64,Float32, andBigFloatinputs against LogExpFunctions 1.0.0 — values match expectations.Test plan
🤖 Generated with Claude Code