From 20598562c69e51d310c71d25152326456e7ba3c1 Mon Sep 17 00:00:00 2001 From: "Chris Rackauckas (Claude)" Date: Sat, 13 Jun 2026 04:56:32 -0400 Subject: [PATCH] QA: restore Aqua deps_compat (add missing [compat] for test extras) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The grouped-tests-ci conversion added `Pkg` to [extras]/[targets].test without a corresponding [compat] entry, which makes the extras sub-check of Aqua.test_deps_compat fail. That was worked around by passing check_extras=false and adding a `@test_broken false` sentinel pointing at issue #83 — hiding the metadata gap instead of fixing it. This adds the one-line metadata fix `Pkg = "1"` to [compat] and removes the check_extras=false weakening plus the sentinel, restoring the full Aqua.test_deps_compat(PoissonRandom). All other QA checks are unchanged. Verified locally with GROUP=QA on julia 1.11: Aqua 10/10, JET 6/6, ExplicitImports 2/2, zero broken, zero failures. Co-Authored-By: Chris Rackauckas Co-Authored-By: Claude Opus 4.8 (1M context) --- Project.toml | 1 + test/qa/qa.jl | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Project.toml b/Project.toml index d164739..a7a2e1f 100644 --- a/Project.toml +++ b/Project.toml @@ -14,6 +14,7 @@ Distributions = "0.25" ExplicitImports = "1.14.0" JET = "0.9, 0.10, 0.11" LogExpFunctions = "0.3.14, 1.0" +Pkg = "1" PrecompileTools = "1.2.0" Random = "1.10" Statistics = "1" diff --git a/test/qa/qa.jl b/test/qa/qa.jl index 40ee2e2..7e6923e 100644 --- a/test/qa/qa.jl +++ b/test/qa/qa.jl @@ -5,10 +5,7 @@ using Test @testset "Aqua" begin Aqua.find_persistent_tasks_deps(PoissonRandom) Aqua.test_ambiguities(PoissonRandom, recursive = false) - # The `extras` sub-check of test_deps_compat fails: the test-only extra `Pkg` - # has no [compat] entry in Project.toml. deps/weakdeps sub-checks still run. - Aqua.test_deps_compat(PoissonRandom; check_extras = false) - @test_broken false # Aqua test_deps_compat extras: `Pkg` lacks a compat entry — tracked in https://github.com/SciML/PoissonRandom.jl/issues/83 + Aqua.test_deps_compat(PoissonRandom) Aqua.test_piracies( PoissonRandom, treat_as_own = []