Skip to content

Setting group volume: Mixed client capabilities #82

@craftbyte

Description

@craftbyte

When using LedFx as a SendSpin client, the server was constantly setting its' volume to 100%. After reporting this and disabling the Volume capability (see LedFx/LedFx#1798), group volume controlls (at least in Music Assistant) are just gone. I believe the spec should account for groups like this and only calculate group volume from supported clients, while ignoring the other clients completely.

To illustrate: Imagine having a group of 1 LedFX (no volume support), 2 SendSpin Pi Receivers (with volume support). The Pis are at 25% and 75%. Thus, the group reads as 50% volume (by just calculating from the Pis). Changing the volume to 40% then applies the volume change of 10% to the Pis, settings them to 15% and 65%, which results in the group volume average of 40%. All this time, the LedFx does not receive any volume commands, nor does the volume on it change, as it doesn't announce a volume capability.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions