From f6cf8cb8772f58bd939aebf2c2a0bdb1fbaf6e53 Mon Sep 17 00:00:00 2001 From: "David J. Rosenbaum" Date: Thu, 18 Jun 2026 23:50:52 -0700 Subject: [PATCH 1/2] Let the user choose if vterm buffers should be killed on exit. --- docker-process.el | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/docker-process.el b/docker-process.el index a0a91c6..d9201fe 100644 --- a/docker-process.el +++ b/docker-process.el @@ -147,6 +147,13 @@ Otherwise, use a non-interactive buffer with ANSI color support." 'docker-process-filter-noninteractive)) (switch-to-buffer-other-window buffer))) +(defcustom docker-vterm-kill-buffer-on-exit nil + "Indicates if docker `vterm' buffers should be killed on exit. + +See `vterm-kill-buffer-on-exit'." + :group 'docker + :type 'boolean) + (defun docker-run-async-with-buffer-vterm (program &optional interactive &rest args) "Execute \"PROGRAM ARGS\" and display output in a new `vterm' buffer. If INTERACTIVE is nil, fall back to shell mode since vterm is interactive." @@ -158,7 +165,7 @@ If INTERACTIVE is nil, fall back to shell mode since vterm is interactive." (if (fboundp 'vterm-other-window) (let* ((process-args (-remove 's-blank? (-flatten args))) (vterm-shell (s-join " " (-insert-at 0 program process-args))) - (vterm-kill-buffer-on-exit nil)) + (vterm-kill-buffer-on-exit docker-vterm-kill-buffer-on-exit)) (vterm-other-window (apply #'docker-utils-generate-new-buffer-name program process-args))) (error "The vterm package is not installed")))) From 95acdc4e64945b14ef97eb7a0b6088d59a446e28 Mon Sep 17 00:00:00 2001 From: "David J. Rosenbaum" Date: Fri, 19 Jun 2026 09:43:18 -0700 Subject: [PATCH 2/2] Remove vterm-kill-buffer-on-exit binding entirely --- docker-process.el | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/docker-process.el b/docker-process.el index d9201fe..a49e1e9 100644 --- a/docker-process.el +++ b/docker-process.el @@ -147,13 +147,6 @@ Otherwise, use a non-interactive buffer with ANSI color support." 'docker-process-filter-noninteractive)) (switch-to-buffer-other-window buffer))) -(defcustom docker-vterm-kill-buffer-on-exit nil - "Indicates if docker `vterm' buffers should be killed on exit. - -See `vterm-kill-buffer-on-exit'." - :group 'docker - :type 'boolean) - (defun docker-run-async-with-buffer-vterm (program &optional interactive &rest args) "Execute \"PROGRAM ARGS\" and display output in a new `vterm' buffer. If INTERACTIVE is nil, fall back to shell mode since vterm is interactive." @@ -164,8 +157,7 @@ If INTERACTIVE is nil, fall back to shell mode since vterm is interactive." (defvar vterm-shell) (if (fboundp 'vterm-other-window) (let* ((process-args (-remove 's-blank? (-flatten args))) - (vterm-shell (s-join " " (-insert-at 0 program process-args))) - (vterm-kill-buffer-on-exit docker-vterm-kill-buffer-on-exit)) + (vterm-shell (s-join " " (-insert-at 0 program process-args)))) (vterm-other-window (apply #'docker-utils-generate-new-buffer-name program process-args))) (error "The vterm package is not installed"))))