Skip to content

Leveling up a poker hand with a different display name during scoring resets the name to default #1399

@nh6574

Description

@nh6574

To recreate, play a Royal Flush and return { level_up = true } in context.before. It will revert the name to Straight Flush and not revert the changes.

It seems to be because SMODS.upgrade_poker_hands checks if the key of the hand is the same as the hand played (saved in SMODS.displayed_hand) but doesn't account for the display name being different.

Maybe in this case it is better to keep the modified name like Vanilla does?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions