-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Right now, we just get the newest 100 lines when getting logs and replace the content in the TextArea.
We can't necessarily get the full logs as firecrest has 5242880 Bytes (5mb) size limitation on the file endpoint, so for larger logs it'd fail. also it'd be slow.
But the /tail endpoint does return a start position and an end position, so it should be feasible to e.g. get the first n lines, then get the next n and append etc.
Right now we update logs every 3 seconds, so there's a risk that if there are more than n lines per 3 seconds, that we can't catch up (of course, it there's more than 5mb per 3 seconds, it's impossible to catch up)
It's also not clear how the start and end position in that endpoint actually work, in my tests, with only 3 log lines, getting the last 100 lines was always (-100,-1), so the indices might be relative (not absolute), which would make appending/deduplicating difficult.