Skip to content

Commit 787e787

Browse files
committed
fix(shop/Select): move 'onKeyDown' from wrapper 'div' to trigger 'button' for a11y
1 parent ed7f3fa commit 787e787

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/components/shop/ui/Select.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,13 @@ export function ShopSelect({
9494
}
9595

9696
return (
97-
<div className={twMerge('relative', className)} onKeyDown={onKeyDown}>
97+
<div className={twMerge('relative', className)}>
9898
<button
9999
ref={triggerRef}
100100
type="button"
101101
aria-haspopup="listbox"
102102
aria-expanded={open}
103+
onKeyDown={onKeyDown}
103104
onClick={() => {
104105
setOpen((o) => !o)
105106
if (!open) setFocused(value ?? options[0]?.value ?? null)

0 commit comments

Comments
 (0)