-
-
Notifications
You must be signed in to change notification settings - Fork 431
feat(core): implement built-in scroll-scaling for large lists #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DivyamUp14
wants to merge
3
commits into
TanStack:main
Choose a base branch
from
DivyamUp14:feat/scroll-scaling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+489
−12
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
bbfc4bf
feat(core): implement built-in scroll-scaling for large lists
DivyamUp14 431a45e
Guard maxScrollSize against invalid values to avoid broken scale math.
DivyamUp14 f40ad74
test(core): assert reference identity and cloning at scaling boundaries
DivyamUp14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| '@tanstack/virtual-core': minor | ||
| --- | ||
|
|
||
| feat: Add built-in scroll-scaling to bypass browser scroll height limits | ||
|
|
||
| Browsers cap `scrollHeight` at approximately 33.5 million pixels, making items at the end of very large lists unreachable. The virtualizer now automatically detects when the total virtual size exceeds the configurable `maxScrollSize` (default: 33,000,000 px) and applies a transparent scale transform to compress the scroll range. | ||
|
|
||
| **New option:** | ||
| - `maxScrollSize` — Maximum physical scroll container size in pixels. Set to `Infinity` to disable scaling. Default: `33_000_000`. | ||
|
|
||
| **New property:** | ||
| - `scale` — The current scale factor (1 when no scaling is active). | ||
|
|
||
| When scaling is active: | ||
| - `getTotalSize()` returns the capped physical size for use as the container's CSS height/width. | ||
| - `getVirtualItems()` returns items with physical coordinates — use `item.start` directly for positioning. | ||
| - `scrollToIndex()`, `scrollToOffset()`, and `scrollBy()` work transparently. | ||
| - Scroll anchoring (resize adjustments for items above the viewport) works correctly through the scale transform. | ||
|
|
||
| When scaling is **not** active (the vast majority of use cases), there is zero overhead — the existing code paths are unchanged. | ||
|
|
||
| This feature is implemented entirely in `virtual-core` and works across all framework adapters (React, Vue, Solid, Svelte, Angular, Lit) with no adapter changes required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.