Skip to content

Commit 34fe5e6

Browse files
committed
Pull request #1: Remove Push Verify code from Ruby FS SDK
Merge in SDK/ruby_telesign_enterprise from feature/PD-91895 to master * commit '4175cf84c39654eef012327706987e4879110267': Update development dependecy version and indent code Fix a comment in VerifyClient class Remove Push Verify code from Ruby FS SDK
2 parents 1ed6917 + 4175cf8 commit 34fe5e6

3 files changed

Lines changed: 23 additions & 32 deletions

File tree

RELEASE

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
2.3.0
2+
3+
- Removed push method in VerifyClient class
4+
15
2.2.2
26

37
- Permits use of net-http-persistent 4.x.x

lib/telesignenterprise/verify.rb

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
module TelesignEnterprise
1111

1212
# The Verify API delivers phone-based verification and two-factor authentication using a time-based, one-time passcode
13-
# sent via SMS message, Voice call or Push Notification.
13+
# sent via SMS message and Voice call.
1414
class VerifyClient < Telesign::RestClient
1515

1616
def initialize(customer_id,
@@ -59,19 +59,6 @@ def smart(phone_number, ucid, **params)
5959
**params)
6060
end
6161

62-
# The Push Verify web service allows you to provide on-device transaction authorization for your end users. It
63-
# works by delivering authorization requests to your end users via push notification, and then by receiving their
64-
# permission responses via their mobile device's wireless Internet connection.
65-
#
66-
# See https://developer.telesign.com/docs/rest_api-verify-push for detailed API documentation.
67-
def push(phone_number, ucid, **params)
68-
69-
self.post(VERIFY_PUSH_RESOURCE,
70-
phone_number: phone_number,
71-
ucid: ucid,
72-
**params)
73-
end
74-
7562
# Retrieves the verification result for any verify resource.
7663
#
7764
# See https://developer.telesign.com/docs/rest_api-verify-transaction-callback for detailed API documentation.

telesignenterprise.gemspec

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
Gem::Specification.new do |s|
2-
s.name = 'telesignenterprise'
3-
s.version = '2.2.2'
4-
s.add_runtime_dependency 'telesign', '~> 2.2.3'
5-
s.licenses = ['MIT']
6-
s.date = '2017-05-02'
7-
s.summary = 'TeleSign Enterprise Ruby SDK'
8-
s.description = 'TeleSign Enterprise Ruby SDK'
9-
s.authors = ['TeleSign']
10-
s.email = 'support@telesign.com'
11-
s.files = Dir['lib/**/*rb']
12-
s.homepage = 'http://rubygems.org/gems/telesign'
2+
s.name = 'telesignenterprise'
3+
s.version = '2.3.0'
4+
s.add_runtime_dependency 'telesign', '~> 2.2.3'
5+
s.licenses = ['MIT']
6+
s.date = '2017-05-02'
7+
s.summary = 'TeleSign Enterprise Ruby SDK'
8+
s.description = 'TeleSign Enterprise Ruby SDK'
9+
s.authors = ['TeleSign']
10+
s.email = 'support@telesign.com'
11+
s.files = Dir['lib/**/*rb']
12+
s.homepage = 'http://rubygems.org/gems/telesign'
1313

14-
s.add_development_dependency 'rake'
15-
s.add_development_dependency 'uuid'
16-
s.add_development_dependency 'mocha'
17-
s.add_development_dependency 'webmock'
18-
s.add_development_dependency 'codecov'
19-
s.add_development_dependency 'simplecov'
20-
s.add_development_dependency 'test-unit'
14+
s.add_development_dependency 'rake', '~> 13.2'
15+
s.add_development_dependency 'uuid', '~> 2.3'
16+
s.add_development_dependency 'mocha', '~> 2.7'
17+
s.add_development_dependency 'webmock', '~> 3.24'
18+
s.add_development_dependency 'codecov', '~> 0.6.0'
19+
s.add_development_dependency 'simplecov', '~> 0.22.0'
20+
s.add_development_dependency 'test-unit', '~> 3.6'
2121
end

0 commit comments

Comments
 (0)