Skip to content

ci: add WASM build and GitHub Pages deployment #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Velli20 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: add WASM build and GitHub Pages deployment #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,81 @@ jobs:
${{ runner.os }}-cargo-min-
- name: Build default feature set
run: cargo build --workspace

build-wasm:
name: Build WebAssembly (Emscripten)
runs-on: ubuntu-latest
timeout-minutes: 30

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Set up Rust toolchain
uses: dtolnay/rust-toolchain@stable
with:
targets: wasm32-unknown-emscripten

- name: Install Emscripten
uses: mymindstorm/setup-emsdk@v14
with:
# Pin to 3.1.x: Skia's pre-built wasm binaries use emscripten-style
# exception handling (invoke_* wrappers). Emscripten 4.x defaults to
# wasm-native exceptions (-fwasm-exceptions) which is incompatible.
version: '3.1.74'
actions-cache-folder: 'emsdk-cache'

- name: Cache cargo registry + git + build
uses: actions/cache@v4
with:
path: |
~/.cargo/registry
~/.cargo/git
target
key: ${{ runner.os }}-cargo-wasm-emsdk3.1.74-${{ hashFiles('**/Cargo.lock') }}
restore-keys: |
${{ runner.os }}-cargo-wasm-emsdk3.1.74-

- name: Build xtask
run: cargo build -p xtask

- name: Build WASM with xtask
run: cargo xtask emscripten --features skia-wasm --emsdk $EMSDK

- name: Prepare deployment artifacts
run: |
mkdir -p deploy
cp examples/web/index.html deploy/
cp examples/web/dist/emscripten.js deploy/
cp examples/web/dist/emscripten.wasm deploy/

- name: Upload Pages artifact
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upload-pages-artifact step runs on all workflow triggers (including PRs), but the deployment only happens on pushes to main. This means artifacts are created and uploaded for PRs even though they are never deployed. Consider adding a conditional to the upload step (if: github.event_name == 'push' && github.ref == 'refs/heads/main') to avoid creating unnecessary artifacts, or split the build-wasm job into separate build and upload steps with different conditions.

Suggested change
- name: Upload Pages artifact
- name: Upload Pages artifact
if: github.event_name == 'push' && github.ref == 'refs/heads/main'

Copilot uses AI. Check for mistakes.
uses: actions/upload-pages-artifact@v3
with:
path: deploy

deploy:
name: Deploy to GitHub Pages
runs-on: ubuntu-latest
needs: [test, minimal, build-wasm]
# Only deploy on push to main (not on PRs)
if: github.event_name == 'push' && github.ref == 'refs/heads/main'

# Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued.
# However, do NOT cancel in-progress runs as we want to allow these production deployments to complete.
concurrency:
group: "pages"
cancel-in-progress: false

permissions:
pages: write
id-token: write

environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}

steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v4
11 changes: 9 additions & 2 deletions xtask/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ fn build_emscripten(
// Check emsdk exists
let emsdk_path = get_emsdk_path(emsdk_override)?;

// Set EMCC_CFLAGS
// Set EMCC_CFLAGS (applies to every emcc invocation: compile + link).
// SUPPORT_LONGJMP must be set explicitly — the emscripten default does
// not propagate when emcc is invoked as a linker through rustc's driver.
let emcc_cflags = [
"--no-entry",
"-sASSERTIONS=1",
Expand All @@ -127,6 +129,7 @@ fn build_emscripten(
"-sENVIRONMENT=web",
"-sERROR_ON_UNDEFINED_SYMBOLS=0",
"-sMAX_WEBGL_VERSION=2",
"-sSUPPORT_LONGJMP=emscripten",
]
.join(" ");

Expand All @@ -135,6 +138,7 @@ fn build_emscripten(
"-C link-args=-sEXPORTED_FUNCTIONS=['_sk_load_pdf','_sk_get_page_count','_sk_render_page','_sk_free_pdf','_malloc','_free']",
"-C link-args=-sEXPORTED_RUNTIME_METHODS=['cwrap','HEAPU8']",
"-C link-args=-sSTANDALONE_WASM=0",
"-C link-args=-sSUPPORT_LONGJMP=emscripten",
]
.join(" ");

Expand Down Expand Up @@ -173,7 +177,10 @@ fn build_emscripten(
.arg("cargo")
.args(&cargo_args)
.env("EMCC_CFLAGS", emcc_cflags)
.env("RUSTFLAGS", rustflags)
.env(
"CARGO_TARGET_WASM32_UNKNOWN_EMSCRIPTEN_RUSTFLAGS",
rustflags,
)
.stdout(Stdio::inherit())
.stderr(Stdio::inherit())
.status()
Expand Down
Loading