-
Notifications
You must be signed in to change notification settings - Fork 198
vmalertmanager: tracing configuration is ignored if VMAlertmanagerConfig is not used #1983
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingwaiting for releaseThe change was merged to upstream, but wasn't released yet.The change was merged to upstream, but wasn't released yet.
Description
Currently, setting .spec.tracingConfig for VMAlertmanager which uses configRawYaml for the configuraiton will lead to silently skipping tracing config.
Seems like early return here -
| if len(pos.configs.All()) == 0 { | |
| return baseCfg, nil | |
| } |
Leads to skipping tracing configuration being applied here -
operator/internal/controller/operator/factory/vmalertmanager/config.go
Lines 110 to 116 in 178ca2d
| if cr.Spec.TracingConfig != nil { | |
| tracingCfg, err := buildTracingConfig(cr, ac) | |
| if err != nil { | |
| return nil, err | |
| } | |
| baseYAMLCfg.TracingConfig = tracingCfg | |
| } |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingwaiting for releaseThe change was merged to upstream, but wasn't released yet.The change was merged to upstream, but wasn't released yet.