Skip to content

vmalertmanager: tracing configuration is ignored if VMAlertmanagerConfig is not used #1983

@zekker6

Description

@zekker6

Currently, setting .spec.tracingConfig for VMAlertmanager which uses configRawYaml for the configuraiton will lead to silently skipping tracing config.
Seems like early return here -

if len(pos.configs.All()) == 0 {
return baseCfg, nil
}

Leads to skipping tracing configuration being applied here -

if cr.Spec.TracingConfig != nil {
tracingCfg, err := buildTracingConfig(cr, ac)
if err != nil {
return nil, err
}
baseYAMLCfg.TracingConfig = tracingCfg
}

Metadata

Metadata

Labels

bugSomething isn't workingwaiting for releaseThe change was merged to upstream, but wasn't released yet.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions