-
Notifications
You must be signed in to change notification settings - Fork 198
ScrapeClass relabelings/metricRelabelings are added after target-specific relabelings #1997
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workingwaiting for releaseThe change was merged to upstream, but wasn't released yet.The change was merged to upstream, but wasn't released yet.
Description
According to the prometheus-operator's ScrapeClass api reference, its relabelings and metricRelabelings are added before the target specific relabelings: https://prometheus-operator.dev/docs/api-reference/api/#monitoring.coreos.com/v1.ScrapeClass
The VictoriaMetrics operator does it the other way around. I suppose this is where it happens:
operator/internal/controller/operator/factory/vmscrapes/vmscrapes.go
Lines 653 to 654 in 87b2d36
| ers.RelabelConfigs = append(ers.RelabelConfigs, scrapeClass.RelabelConfigs...) | |
| ers.MetricRelabelConfigs = append(ers.MetricRelabelConfigs, scrapeClass.MetricRelabelConfigs...) |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingwaiting for releaseThe change was merged to upstream, but wasn't released yet.The change was merged to upstream, but wasn't released yet.