Skip to content

sec: resolve cryptographic timing attack vulnerability in admin authentication (#18) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishabh0510rishabh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

sec: resolve cryptographic timing attack vulnerability in admin authentication (#18) #21

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f0e0a
Add env example and config; secure admin token
rishabh0510rishabh May 17, 2026
f17583c
Remove accidental duplicate config files from package directory
rishabh0510rishabh May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion humane_proxy/api/admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from __future__ import annotations

import csv
import hmac
import io
import json
import logging
Expand Down Expand Up @@ -60,7 +61,7 @@ def _require_admin(
"environment variable to enable it."
),
)
if credentials is None or credentials.credentials != admin_key:
if credentials is None or not hmac.compare_digest(credentials.credentials, admin_key):
raise HTTPException(
status_code=401,
detail="Invalid or missing Bearer token.",
Expand Down
Loading