"blacklistEvents": [] not working

[dataedgehungary]

Hi!

I cannot figure out where do I go wrong. I am trying to remove the default blacklist of the primary indicator. Here is my engine.json:

Fresh docker deployment from the newest dev.

{
    "engineId": "ecom_ur",
    "engineFactory": "com.actionml.engines.ur.UREngine",
    "sparkConf": {
	"master": "local",
        "spark.serializer": "org.apache.spark.serializer.KryoSerializer",
        "spark.kryo.registrator": "org.apache.mahout.sparkbindings.io.MahoutKryoRegistrator",
        "spark.kryo.referenceTracking": "false",
        "spark.kryoserializer.buffer": "300m",
        "spark.executor.memory": "20g",
        "spark.driver.memory": "10g",
        "spark.es.index.auto.create": "true",
        "spark.es.nodes": "192.168.40.225",
        "spark.es.nodes.wan.only": "true"
    },
    "algorithm":{
        "indicators": [ 
            {
                "name": "buy"
            }
        ],
	"maxQueryEvents": 19,
	"blacklistEvents": [],
	"maxCorrelatorsPerEventType": 49
    }
}

But it does not affect the generated engine... There is an issue also with the "maxQueryEvents" btw. Below is the log for the generated engine..

Engine-id: ecom_ur. Initialized with JSON: {"engineId":"ecom_ur","engineFactory":"com.actionml.engines.ur.UREngine","sparkConf":{"master":"local","spark.serializer":"org.apache.spark.serializer.KryoSerializer","spark.kryo.registrator":"org.apache.mahout.sparkbindings.io.MahoutKryoRegistrator","spark.kryo.referenceTracking":"false","spark.kryoserializer.buffer":"300m","spark.executor.memory":"20g","spark.driver.memory":"10g","spark.es.index.auto.create":"true","spark.es.nodes":"192.168.40.225","spark.es.nodes.wan.only":"true"},"algorithm":{"indicators":[{"name":"buy"}],"maxQueryEvents":19,"blacklistEvents":[],"maxCorrelatorsPerEventType":49}}

10:39:51.697 INFO  URAlgorithm       - Engine-id: ecom_ur. Events to alias mapping: Map(buy -> buy)
10:39:51.697 INFO  package$          - 
╔════════════════════════════════════════════════════════════════════════════════╗
║ URAlgorithm initialization parameters including "defaults"                     ║
║ ══════════════════════════════════════════════════════════════════════════════ ║
║ ES index name:                          null                                   ║
║ ES type name:                           items                                  ║
║ RecsModel:                              all                                    ║
║ Indicators:                             List(IndicatorParams(buy,None,None,None,None)) ║
║ ══════════════════════════════════════════════════════════════════════════════ ║
║ Random seed:                            326194065                              ║
║ MaxCorrelatorsPerEventType:             49                                     ║
║ MaxEventsPerEventType:                  500                                    ║
║ BlacklistEvents:                        List(buy)                              ║
║ ══════════════════════════════════════════════════════════════════════════════ ║
║ User bias:                              1.0                                    ║
║ Item bias:                              1.0                                    ║
║ Max query events:                       1000                                   ║
║ Limit:                                  20                                     ║
║ ══════════════════════════════════════════════════════════════════════════════ ║
║ Rankings:                                                                      ║
║ popular                                 Some(popRank)                          ║
╚════════════════════════════════════════════════════════════════════════════════╝

I would really appreciate some insight. I tried all possible combination for the JSON.. ( [[]], [{}], [""], etc...)

[zebraf1]

The correct configuration parameter name is blacklistIndicators, not blacklistEvents - try that.
This was changed in 0.5.0, but documentation has not been updated. I have made a PR for this:
actionml/docs.actionml.com#18

[zebraf1]

maxQueryEvents value is not taken directly from algorithm params.

Code:
// get max total user history events for the ES query
// this assumes one event doesn't happen more than 10 times more often than another
// not ideal but avoids one query to the event store per event type
maxQueryEvents = params.indicators.foldLeftInt { (previous, indicator) =>
previous + (indicator.maxIndicatorsPerQuery.getOrElse(DefaultURAlgoParams.MaxQueryEvents) * DefaultURAlgoParams.FudgeFactor)
}

[pferrel]

@dataedgehungary yes, as @zebraf1 says, the param for config is blacklistIndicators

We have a typo on the site that calls these blacklistEvents This will be fixed

Fixed now: https://actionml.com/docs/h_ur_config#complete-ur-engine-configuration-specification