Commit 0dca021
feat: sync ADCP schemas to latest, add brand compat and AAO member API (#132)
* feat: sync ADCP schemas to latest, add brand compat layer and AAO member API
- Update ADCP_VERSION from 3.0.0-beta.3 to latest; sync all 274 schemas
- Remove brand-manifest.json (dropped upstream); keep BrandManifest as
backwards-compat stub in _generated.py for existing imports
- Add brand/brand_manifest cross-population on ResolvedBrand so both field
names are always accessible regardless of which the registry returns
- Replace lookup_operator/lookup_operators with lookup_brand — operators are
brands in the AAO registry, no separate endpoint needed
- Add Member type and list_members/get_member to RegistryClient for the AAO
member directory (/api/members)
- Fix FieldModel.format_ → FieldModel.format (format is not a Python keyword)
- Fix CreateMediaBuyRequest test: brand_manifest field replaced by brand ref
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: resolve CI failures for BrandManifest and constr mypy errors
Two CI failures were found on PR #132:
1. Schema validation: NameError for BrandManifest in _generated.py
- consolidate_exports.py hardcoded BrandManifest.model_rebuild() but
BrandManifest is no longer defined (schema removed upstream in latest)
- Fix: remove BrandManifest.model_rebuild() call; emit a backwards-compat
stub class in the generated _generated.py output so existing imports work
2. Mypy valid-type errors in 5 generated files
- datamodel-code-generator emits constr(pattern=...) as dict key types
- mypy's Pydantic v2 plugin rejects this; requires Annotated[str, StringConstraints(...)]
- Fix: add fix_constr_type_annotations() to post_generate_fixes.py to
automatically rewrite the pattern after every schema sync
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: apply black formatting to _generated.py to match CI output
The local consolidate_exports.py run couldn't format with black
(not installed in system Python), leaving _generated.py with
single-line imports. CI has black installed, so it reformats to
multi-line, causing the validation check to always fail with a diff.
Pre-format the committed _generated.py with black so it matches
CI's regenerated output.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: use uv run black in consolidate_exports.py for consistent formatting
When run outside the uv virtualenv, sys.executable may not have black
installed. This caused consolidate_exports.py to silently skip formatting,
producing single-line imports that CI's black would then reformat differently.
Try uv run black first (always available in this project), fall back to
sys.executable for environments without uv.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: use pytest.mark.asyncio consistently in test_raises_on_invalid_limit
The test was using asyncio.run() directly in a sync method while all
surrounding tests use @pytest.mark.asyncio. Align for consistency.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 9bfb0fb commit 0dca021
File tree
70 files changed
+1738
-1862
lines changed- schemas/cache
- core
- requirements
- creative/asset-types
- enums
- extensions
- media-buy
- property
- protocol
- scripts
- src/adcp
- types
- generated_poc
- content_standards
- core
- requirements
- enums
- media_buy
- property
- protocol
- tests
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
70 files changed
+1738
-1862
lines changedLarge diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
| 153 | + | |
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
192 | | - | |
| 192 | + | |
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
| 238 | + | |
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
| |||
310 | 310 | | |
311 | 311 | | |
312 | 312 | | |
313 | | - | |
| 313 | + | |
314 | 314 | | |
315 | 315 | | |
316 | 316 | | |
| |||
0 commit comments