Skip to content

Type stability#10

Merged
nmheim merged 7 commits intomasterfrom
type-stability
Dec 18, 2019
Merged

Type stability#10
nmheim merged 7 commits intomasterfrom
type-stability

Conversation

@nmheim
Copy link
Copy Markdown
Member

@nmheim nmheim commented Dec 18, 2019

adresses #8

I am sorry that I have not checked that before but the conditional dists were not type stable.
I had to slightly change the interface of creating CMeanGaussians, but I think it is actually nicer now:

p  = CMeanGaussian{DiagVar}(mapping, var)

no need for the T anymore, where needed we can get it from the variance :)
what do you guys think? @vitskvara @smidl @pevnak

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 18, 2019

Codecov Report

Merging #10 into master will increase coverage by 4.92%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #10      +/-   ##
=========================================
+ Coverage   87.37%   92.3%   +4.92%     
=========================================
  Files           8       8              
  Lines         103     104       +1     
=========================================
+ Hits           90      96       +6     
+ Misses         13       8       -5
Impacted Files Coverage Δ
src/abstract_cgaussian.jl 100% <ø> (ø) ⬆️
src/abstract_pdfs.jl 100% <ø> (ø) ⬆️
src/cmeanvar_gaussian.jl 100% <100%> (+23.8%) ⬆️
src/gaussian.jl 100% <100%> (ø) ⬆️
src/constspec_gaussian.jl 82.6% <50%> (-4.35%) ⬇️
src/cmean_gaussian.jl 86.95% <87.5%> (+1.95%) ⬆️
src/nogradarray.jl 75% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e999bb6...ceae682. Read the comment docs.

@nmheim nmheim changed the title CMeanGaussian is now type stable Type stability Dec 18, 2019
@nmheim nmheim merged commit 4a674b1 into master Dec 18, 2019
@nmheim nmheim deleted the type-stability branch December 18, 2019 07:10
This was referenced Dec 18, 2019
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (e999bb6) to head (ceae682).
Report is 47 commits behind head on master.

Files with missing lines Patch % Lines
src/cmean_gaussian.jl 87.50% 1 Missing ⚠️
src/constspec_gaussian.jl 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   87.37%   92.30%   +4.92%     
==========================================
  Files           8        8              
  Lines         103      104       +1     
==========================================
+ Hits           90       96       +6     
+ Misses         13        8       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants