fix: remove last message role restriction in chat completion endpoint#2
Open
amumu96 wants to merge 4 commits into
Open
fix: remove last message role restriction in chat completion endpoint#2amumu96 wants to merge 4 commits into
amumu96 wants to merge 4 commits into
Conversation
Remove the validation that required the last message role to be "user", "system", or "tool" in the create_chat_completion endpoint. This aligns with OpenAI API behavior and fixes 400 errors from frameworks like LangGraph that pass conversation history including assistant messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The test expected a 400 when the last message role was "assistant", but the previous commit intentionally removed that restriction. Update the test to expect a successful completion response instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The underlying model may not return a standard completion response for assistant-terminated conversations, so just assert the API no longer rejects the request with a 400. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The llama.cpp backend rejects assistant response prefill with enable_thinking, causing a 500. The API validation change is already covered by the existing test that sends only system messages (which passes since it doesn't require assistant as last role). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"user","system", or"tool"in thecreate_chat_completionendpointmessagesempty check, aligning with OpenAI API behaviorSynced from enterprise MR: orbitai/xinference-enterprise/xinference-backend!428
Test plan
🤖 Generated with Claude Code