fix the 3d orderbok orientation

Author: andersc

docs/RLOrderBookVis.md

@@ -126,7 +126,7 @@ struct RLOrderBookVisStyle {
 |--------|-------------|
 | `update(float aDt)` | Update animations and textures (call each frame) |
 | `draw2D() const` | Draw the 2D heatmap view |
-| `draw3D(const Camera3D &rCamera) const` | Draw the 3D landscape view |
+| `draw3D(const Camera3D &rCamera) const` | Draw the 3D landscape view (renders to internal texture for proper viewport centering within bounds) |
 
 ### Getters
 
@@ -280,6 +280,7 @@ int main() {
 - **Y-axis (height)**: Liquidity/size
 - Separate meshes for bids and asks
 - Color corresponds to height/intensity
+- Renders to an internal RenderTexture for proper centering within bounds
 
 ### Interpreting the Display
 - **Bright walls**: Large resting orders (support/resistance)

src/charts/RLOrderBookVis.cpp

@@ -35,6 +35,7 @@ RLOrderBookVis::RLOrderBookVis(Rectangle aBounds, size_t aHistoryLength, size_t
 RLOrderBookVis::~RLOrderBookVis() {
     cleanupTexture();
     cleanupMesh();
+    cleanupRenderTarget();
 }
 
 void RLOrderBookVis::cleanupTexture() {
@@ -59,6 +60,33 @@ void RLOrderBookVis::cleanupMesh() {
     }
 }
 
+void RLOrderBookVis::cleanupRenderTarget() const {
+    if (mRenderTargetValid && mRenderTarget.id != 0) {
+        UnloadRenderTexture(mRenderTarget);
+        mRenderTarget = RenderTexture2D{};
+        mRenderTargetValid = false;
+        mRenderTargetWidth = 0;
+        mRenderTargetHeight = 0;
+    }
+}
+
+void RLOrderBookVis::ensureRenderTarget() const {
+    int lWidth = (int)mBounds.width;
+    int lHeight = (int)mBounds.height;
+
+    // Recreate if dimensions changed or not valid
+    if (mRenderTargetValid && (mRenderTargetWidth != lWidth || mRenderTargetHeight != lHeight)) {
+        cleanupRenderTarget();
+    }
+
+    if (!mRenderTargetValid || mRenderTarget.id == 0) {
+        mRenderTarget = LoadRenderTexture(lWidth, lHeight);
+        mRenderTargetValid = (mRenderTarget.id != 0);
+        mRenderTargetWidth = lWidth;
+        mRenderTargetHeight = lHeight;
+    }
+}
+
 void RLOrderBookVis::setBounds(Rectangle aBounds) {
     mBounds = aBounds;
 }
@@ -770,6 +798,16 @@ void RLOrderBookVis::draw3D(const Camera3D& rCamera) const {
         return;
     }
 
+    // Ensure render target exists and matches bounds dimensions
+    ensureRenderTarget();
+    if (!mRenderTargetValid || mRenderTarget.id == 0) {
+        return;
+    }
+
+    // Render 3D scene to offscreen texture
+    BeginTextureMode(mRenderTarget);
+    ClearBackground(mStyle.mBackground);
+
     BeginMode3D(rCamera);
 
     // Center the mesh
@@ -809,5 +847,17 @@ void RLOrderBookVis::draw3D(const Camera3D& rCamera) const {
     DrawMesh(mAskMesh, lMat, lTransform);
 
     EndMode3D();
+    EndTextureMode();
+
+    // Draw the render texture at the bounds position
+    // Note: RenderTexture Y is flipped, so we use negative height in source rect
+    const Rectangle lSrc = {0, 0, (float)mRenderTargetWidth, -(float)mRenderTargetHeight};
+    const Rectangle lDst = {mBounds.x, mBounds.y, mBounds.width, mBounds.height};
+    DrawTexturePro(mRenderTarget.texture, lSrc, lDst, Vector2{0, 0}, 0.0f, WHITE);
+
+    // Draw border on top if enabled
+    if (mStyle.mShowBorder) {
+        DrawRectangleLinesEx(mBounds, mStyle.mBorderThickness, mStyle.mBorderColor);
+    }
 }
 

src/charts/RLOrderBookVis.h

@@ -159,6 +159,12 @@ class RLOrderBookVis {
     bool mMeshValid{false};
     bool mMeshDirty{true};
 
+    // 3D render target for proper viewport centering
+    mutable RenderTexture2D mRenderTarget{};
+    mutable bool mRenderTargetValid{false};
+    mutable int mRenderTargetWidth{0};
+    mutable int mRenderTargetHeight{0};
+
     // Internal helpers
     void ensureBuffers();
     void rebuildLUT();
@@ -168,6 +174,8 @@ class RLOrderBookVis {
     void updateMeshData();
     void cleanupTexture();
     void cleanupMesh();
+    void cleanupRenderTarget() const;
+    void ensureRenderTarget() const;
 
     // Price mapping helpers
     [[nodiscard]] float priceToNormalized(float aPrice) const;

src/examples/orderbook.cpp

@@ -1,6 +1,4 @@
 
-//The orderbook visualization 3D mode is WIP and not 100% correct
-
 // orderbook.cpp
 // Order Book Visualization Demo
 // Demonstrates 2D heatmap and 3D landscape views of depth-of-market data
@@ -346,14 +344,8 @@ int main() {
             DrawTextEx(lFont, "Time ->", Vector2{lBounds2D.x + lBounds2D.width/2 - 30, lBounds2D.y + lBounds2D.height + 15}, 16, 1.0f, Color{120, 120, 130, 255});
             DrawTextPro(lFont, "Price", Vector2{lBounds2D.x - 25, lBounds2D.y + lBounds2D.height/2 + 20}, Vector2{0, 0}, -90.0f, 16, 1, Color{120, 120, 130, 255});
         } else {
-            // 3D view
-            DrawRectangle((int)lBounds2D.x, (int)lBounds2D.y, (int)lBounds2D.width, (int)lBounds2D.height, Color{15, 17, 22, 255});
-            DrawRectangleLinesEx(lBounds2D, 1.0f, Color{50, 55, 65, 255});
-
-            // Draw 3D in a viewport-like area
-            BeginScissorMode((int)lBounds2D.x, (int)lBounds2D.y, (int)lBounds2D.width, (int)lBounds2D.height);
+            // 3D view - draw3D handles viewport centering internally via RenderTexture
             lOrderBook.draw3D(lCamera);
-            EndScissorMode();
         }
 
         // Info panel