Productionize 'Find & Replace'

[david-allison]

@ZornHadNoChoice would like this in in 2.24, I agree. It's currently a developer-only option

Steps remaining IMO:

• Fix a state restore bug: when we select specific notes and move the app to the background where it's killed, when coming back, the dialog will work with an empty notes selection as the browser's ViewModel is a new instance and hasn't yet restored its data. This is problematic because the user is going to change his entire collection while visually just some notes are selected. Fix state restore bug in FindAndReplaceDialogFragment #19981
• Use ViewBinding Convert FindAndReplaceDialogFragment to ViewBinding #19940
• Minor Ui tweaks to make it look more material
• (Optional?)Implement a ViewModel: this would allow to add more testing(my initial tests became flaky, Espresso and our background work don't play too well), potentially makes it easier to fix the above bug

[david-allison]

@lukstbit This was added in:

• feat: Add developer option for find and replace #17897

When you have a second, could you add subtasks which are blocking this being moved to production?

[lukstbit]

I was for sure going to propose this for 2.24, even funnier is that I was going to ask Zorn if he wants(and hasn't already) to have a look at this seeing that he's been an enthusiastic tester for the app:))

I added some steps, the bug is problematic for the few cases when it's going to happen so that's probably blocking.

edit: I'll look at this in the next days.