Av/40 migrate OIDC implementation#42
Open
anushkavidanage wants to merge 14 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Complete re-engineering of
solid_authfrom a hand-rolled OIDC implementation to one built on the OpenID-certified package:oidc.What was removed
The entire forked
openid_clientsource tree (~1 300 lines acrosslib/src/openid/) has been deleted, along with the old platform-splitauth_manager/abstractions (web_auth_manager.dart,auth_manager_stub.dart),solid_auth_client.dart,solid_auth_issuer.dart, andplatform_info.dart. These were maintaining a custom fork of an archived library; all OIDC protocol logic (discovery, PKCE, token exchange, refresh, logout) is now delegated topackage:oidc.What was added
SolidAuthManager- single typed facade;authenticate(webId),login(),logout()SolidOidcConfig- typed config objectSolidAuthData- immutable typed auth result (.accessToken, .webId, .idToken, …)DpopTokenGenerator- static DPoP proof builder; both token-endpoint and resource-server variantsWebIdUtils.getIssuer()- same signature, now using typed HTTPSolidScopes- named scope constantsRelated Issues
#40
anusii/solidpod#641
anusii/solidui#270
Type of Change
How To Test?
cd example && flutter run), enter a WebID, tap LOGIN, complete the browser flow. Confirm you reach the private resource screen and the displayed access token is valid.Authorization: DPoP …+DPoP: <proof>headers.genDpopToken(url, keyPair, jwk, method)signature still compiles via theDpopTokenGenerator.generate()legacy-compatible static method.Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising