Amogh/optimize login latency#317
Open
Amoghhosamane wants to merge 5 commits into
Open
Conversation
Amoghhosamane
force-pushed
the
Amogh/optimize_login_latency
branch
from
eaeab24 to
f67b2e1
Compare
…check - Reorder imports to follow Flutter → external packages → project structure - Add blank lines between each import group - Disable conflicting directives_ordering lint rule in analysis_options.yaml (import_order_lint and directives_ordering are mutually exclusive) - Apply dart format to all affected files Affected files: lib/src/utils/solid_file_operations_download.dart lib/src/utils/solid_file_operations_upload.dart lib/src/widgets/solid_about_button.dart lib/src/widgets/solid_file_operations.dart lib/src/widgets/solid_file_uploader.dart lib/src/widgets/solid_file_uploader_helpers.dart lib/src/widgets/solid_login_build_helper.dart lib/src/widgets/solid_login_buttons.dart lib/src/widgets/solid_nav_drawer_header.dart lib/src/widgets/solid_nav_drawer_url_helper.dart lib/src/widgets/solid_profile_editor.dart lib/src/widgets/solid_scaffold_helpers.dart lib/src/widgets/solid_status_bar.dart
- Reorganize imports in 13 target files to follow Flutter -> external -> project hierarchy. - Run import_order on the entire codebase to fix all 158+ violations. - Disable directives_ordering lint in analysis_options.yaml to support import_order_lint grouping rules. - Format all files with dart format.
…figuration - Enforced Flutter -> External -> Project import hierarchy with blank lines. - Added import_order configuration to pubspec.yaml for both root and example. - Disabled conflicting directives_ordering lint in analysis_options.yaml. - Applied dart format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Addresses the login performance bottlenecks reported in issue #224 and synchronizes the branch with the latest upstream/dev architecture changes.
Key optimizations and fixes:
Future.wait()to reduce sequential async latency.setState()calls.These changes improve login responsiveness and reduce unnecessary I/O overhead without changing user-visible behavior.
Related Issues
Closes #224
Type of Change
How To Test?
Confirmed:
Checklist
Screenshots included here/in linked issue #
Changes adhere to the style and coding guidelines
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged and published in downstream modules
The update contains no confidential information
The update has no duplicated content
No lint check errors are related to these changes (
flutter analyze lib)Integration test
dart testoutput or screenshot included in issue #I tested the PR on these devices:
I have identified reviewers
The PR has been approved by reviewers
Finalising