CLOUDSTACK-9727 Password reset discrepancy in RVR when one of the Router is not in Running state.

Author: bvbharat

server/src/com/cloud/network/element/VirtualRouterElement.java

@@ -779,24 +779,37 @@ public boolean savePassword(final Network network, final NicProfile nic, final V
         final DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
         final NetworkTopology networkTopology = networkTopologyContext.retrieveNetworkTopology(dcVO);
 
-        // If any router is running then send save password command otherwise
-        // save the password in DB
+        // If any router is not running then save the password in DB
+        List<VirtualRouter> routerList = new ArrayList<VirtualRouter>();
+        //applied true implies we have applied the password successfully on at
+        //least one router. save true implies we have to save the password to send
+        //it to the remaining routers.
+        Boolean applied = true, save = false;
         for (final VirtualRouter router : routers) {
             if (router.getState() == State.Running) {
-                return networkTopology.savePasswordToRouter(network, nic, uservm, router);
-            }
+                routerList.add(router);
+            } else save = true;
         }
-        final String password = (String) uservm.getParameter(VirtualMachineProfile.Param.VmPassword);
-        final String password_encrypted = DBEncryptionUtil.encrypt(password);
-        final UserVmVO userVmVO = _userVmDao.findById(vm.getId());
-
-        _userVmDao.loadDetails(userVmVO);
-        userVmVO.setDetail("password", password_encrypted);
-        _userVmDao.saveDetails(userVmVO);
+        for (VirtualRouter router : routerList) {
+            applied = networkTopology.savePasswordToRouter(network, nic, uservm, router);
+            if (!applied)
+                 break;
+        }
+        if (save && applied) {
+            final String password = (String) uservm.getParameter(VirtualMachineProfile.Param.VmPassword);
+            final String password_encrypted = DBEncryptionUtil.encrypt(password);
+            final UserVmVO userVmVO = _userVmDao.findById(vm.getId());
 
-        userVmVO.setUpdateParameters(true);
-        _userVmDao.update(userVmVO.getId(), userVmVO);
+            _userVmDao.loadDetails(userVmVO);
+            userVmVO.setDetail("password", password_encrypted);
+            _userVmDao.saveDetails(userVmVO);
 
+            userVmVO.setUpdateParameters(true);
+            _userVmDao.update(userVmVO.getId(), userVmVO);
+        }
+        if (!save && !applied) {
+            return false;
+        }
         return true;
     }