Skip to content

Commit 848860d

Browse files
ustcweizhouyadvr
authored andcommitted
security_group.py: fix NameError: name 'd' is not defined (#3641)
in agent.log on a host running with cloudstack 4.14.0.0-SNAPSHOT, it gives error root@node212:~# /usr/share/cloudstack-common/scripts/vm/network/security_group.py get_rule_logs_for_vms Traceback (most recent call last): File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 1272, in <module> get_rule_logs_for_vms() File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 758, in get_rule_logs_for_vms vms = virshlist(state) File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 104, in virshlist alldomains = [d for domain in map(conn.lookupByID, conn.listDomainsID())] File "/usr/share/cloudstack-common/scripts/vm/network/security_group.py", line 104, in <listcomp> alldomains = [d for domain in map(conn.lookupByID, conn.listDomainsID())] NameError: name 'd' is not defined
1 parent 9258c7c commit 848860d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

scripts/vm/network/security_group.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ def virshlist(states):
101101

102102
conn = get_libvirt_connection()
103103

104-
alldomains = [d for domain in map(conn.lookupByID, conn.listDomainsID())]
105-
alldomains += [d for domain in map(conn.lookupByName, conn.listDefinedDomains())]
104+
alldomains = [domain for domain in map(conn.lookupByID, conn.listDomainsID())]
105+
alldomains += [domain for domain in map(conn.lookupByName, conn.listDefinedDomains())]
106106

107107
domains = []
108108
for domain in alldomains:

0 commit comments

Comments
 (0)