Skip to content

Commit 95fbe7c

Browse files
DaanHooglandyadvr
authored andcommitted
datamotion: snapshot failure diagnostics unhidden (#3666)
Diagnostics are hard when a snapshot fails if a null pointer occurs. This is because no stack trace or location of the error is logged. I.E. 2019-10-21 12:55:00,056 DEBUG [o.a.c.s.m.AncientDataMotionStrategy] (Work-Job-Executor-131:ctx-80420156 job-10033827/job-10033828 ctx-4864e2f5) (logid:21454564) copy snasphot failed: java.lang.NullPointerException
1 parent 41275ab commit 95fbe7c

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ protected Answer copySnapshot(DataObject srcData, DataObject destData) {
564564
}
565565
return answer;
566566
} catch (Exception e) {
567-
s_logger.debug("copy snasphot failed: " + e.toString());
567+
s_logger.debug("copy snasphot failed: ", e);
568568
if (cacheData != null) {
569569
cacheMgr.deleteCacheObject(cacheData);
570570
}

0 commit comments

Comments
 (0)