Validate project ID in findProjectRoles method

Tonitzpp · web-flow · commit db353f1fa22d · 2026-05-15T08:54:00.000-03:00
diff --git a/server/src/main/java/org/apache/cloudstack/acl/ProjectRoleManagerImpl.java b/server/src/main/java/org/apache/cloudstack/acl/ProjectRoleManagerImpl.java
@@ -168,7 +168,7 @@ public ProjectRole findProjectRole(Long roleId, Long projectId) {
 
     @Override
     public List<ProjectRole> findProjectRoles(Long projectId, String keyword) {
-        if (projectId == null) {
+        if (projectId == null || projectId < 1L || projectDao.findById(projectId) == null) {
             logger.warn("Invalid project ID provided; thus, an empty list is being returned.");
             return Collections.emptyList();
         }

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ public ProjectRole findProjectRole(Long roleId, Long projectId) {`
`168`	`168`
`169`	`169`	`@Override`
`170`	`170`	`public List<ProjectRole> findProjectRoles(Long projectId, String keyword) {`
`171`		`- if (projectId == null) {`
	`171`	`+ if (projectId == null \|\| projectId < 1L \|\| projectDao.findById(projectId) == null) {`
`172`	`172`	`logger.warn("Invalid project ID provided; thus, an empty list is being returned.");`
`173`	`173`	`return Collections.emptyList();`
`174`	`174`	`}`