Replace JDom with Domtrip

[kwin]

Affected version

3.1.1

Bug description

Lots of issues are related to how rewriting POMs with JDOM works (e.g. wrong indentation). By switching from JDom to https://github.com/maveniverse/domtrip we should get a much more solid codebase.

[kwin]

@cstamas Is DOMTrip ready for using it inside m-release?

[cstamas]

@gnodet ping, but imo yes

[michael-o]

@cstamas Is DOMTrip ready for using it inside m-release?

This would make Maven Release unusable with Maven 3 because it requires Java 17.

[kwin]

Java 17 is fully supported in plugins/extensions since 3.9.6: apache/maven#8732

[michael-o]

Java 17 is fully supported in plugins/extensions since 3.9.6: apache/maven#8732

Require, not support

[gnodet]

Java 17 is fully supported in plugins/extensions since 3.9.6: apache/maven#8732

Require, not support

One possibility would be to keep both in the class path and try to use Domtrip if possible, else default to JDom.

[kwin]

I still don’t see why

This would make Maven Release unusable with Maven 3 because it requires Java 17.

As said before Java 17 plugins work fine in Maven 3.9.6. If it is only dependencies in Java 17 bytecode without Sisu logic even older ones.

[michael-o]

I still don’t see why

This would make Maven Release unusable with Maven 3 because it requires Java 17.

As said before Java 17 plugins work fine in Maven 3.9.6. If it is only dependencies in Java 17 bytecode without Sisu logic even older ones.

This I don't understand since Domtrip has a hard requirement on 17.

[kwin]

Right, but the question is why you consider this incompatible with Maven 3….

[michael-o]

Right, but the question is why you consider this incompatible with Maven 3….

I didn't say that. Please re-read. Maven 3 won't run on Java 8 anymore.

[kwin]

You said

This would make Maven Release unusable with Maven 3

I beg to differ

[michael-o]

You said

This would make Maven Release unusable with Maven 3

I beg to differ

This I don't neither how it would continue to run on 8 with 17 bytecode