diff --git a/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx b/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx index 4353951a715b..62b102248f30 100644 --- a/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx +++ b/superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx @@ -79,7 +79,7 @@ const onClick = ( const StyledButton = styled.span` button { - line-height: 13px; + line-height: 1; min-width: auto !important; padding: 0 ${({ theme }) => theme.sizeUnit * 3}px 0 ${({ theme }) => theme.sizeUnit * 2}px; diff --git a/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx b/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx index bf1b0ab2a2be..020c88c4080b 100644 --- a/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx +++ b/superset-frontend/src/SqlLab/components/ScheduleQueryButton/index.tsx @@ -108,7 +108,6 @@ export const StyledButtonComponent = styled(Button)` background: none; text-transform: none; padding: 0px; - font-size: 14px; font-weight: ${theme.fontWeightNormal}; margin-left: 0; &:disabled { diff --git a/superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx b/superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx index f03f399583cd..235274a491b8 100644 --- a/superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx +++ b/superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx @@ -81,7 +81,7 @@ const StyledEditableTabs = styled(EditableTabs)` `; const StyledTab = styled.span` - line-height: 24px; + line-height: 1.5; `; const TabTitle = styled.span` diff --git a/superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx b/superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx index dbe3c91c8c72..2cf109eb6dbc 100644 --- a/superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx +++ b/superset-frontend/src/dashboard/components/CustomizationsBadge/index.tsx @@ -83,7 +83,7 @@ const StyledTag = styled(Tag)` vertical-align: middle; color: ${theme.colorTextSecondary}; margin-right: ${theme.sizeUnit * 0.5}px; - font-size: 12px; + font-size: ${theme.fontSizeSM}px; &:hover { color: ${theme.colorText}; } diff --git a/superset-frontend/src/dashboard/components/SliceHeader/index.tsx b/superset-frontend/src/dashboard/components/SliceHeader/index.tsx index be29e3c8e89f..c38b17fcd1af 100644 --- a/superset-frontend/src/dashboard/components/SliceHeader/index.tsx +++ b/superset-frontend/src/dashboard/components/SliceHeader/index.tsx @@ -100,7 +100,7 @@ const ChartHeaderStyles = styled.div` & > .header-controls { display: flex; align-items: center; - height: 24px; + min-height: 24px; } .dropdown.btn-group { diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx index 9fcf2ab00964..04132d7dd9a4 100644 --- a/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx +++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx @@ -67,7 +67,7 @@ const RefreshTooltip = styled.div` height: auto; margin: ${theme.sizeUnit}px 0; color: ${theme.colorTextLabel}; - line-height: 21px; + line-height: 1.5; display: flex; flex-direction: column; align-items: flex-start; @@ -558,7 +558,8 @@ const SliceHeaderControls = ( <> {isFullSize && ( { props.handleToggleFullSize(); }} diff --git a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx index 3aa6a1415d3a..d67eddcff124 100644 --- a/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx +++ b/superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterLabel.tsx @@ -79,15 +79,15 @@ const ContentStyleWrapper = styled.div` .control-label { font-size: ${theme.fontSizeSM}px; - line-height: 16px; + line-height: 1.2; margin: 8px 0; } .section-title { font-style: normal; font-weight: ${theme.fontWeightStrong}; - font-size: 15px; - line-height: 24px; + font-size: ${theme.fontSize}px; + line-height: 1.5; margin-bottom: 8px; } diff --git a/superset-frontend/src/features/home/Menu.tsx b/superset-frontend/src/features/home/Menu.tsx index 1849e8a2e2d6..439e67189755 100644 --- a/superset-frontend/src/features/home/Menu.tsx +++ b/superset-frontend/src/features/home/Menu.tsx @@ -74,7 +74,7 @@ const StyledBrandText = styled.div` justify-content: center; span { - max-width: ${theme.sizeUnit * 58}px; + max-width: 100%; white-space: nowrap; overflow: hidden; text-overflow: ellipsis; @@ -175,8 +175,8 @@ const StyledRow = styled(Row)` const StyledCol = styled(Col)` ${({ theme }) => css` display: flex; - gap: ${theme.sizeUnit * 4}px; flex-wrap: wrap; + gap: ${theme.sizeUnit * 4}px; `} `; diff --git a/superset-frontend/src/features/home/SubMenu.tsx b/superset-frontend/src/features/home/SubMenu.tsx index f71892fb5014..fe3fd23fc060 100644 --- a/superset-frontend/src/features/home/SubMenu.tsx +++ b/superset-frontend/src/features/home/SubMenu.tsx @@ -54,7 +54,7 @@ const StyledHeader = styled.div<{ backgroundColor?: string }>` text-align: left; font-size: 18px; display: inline-block; - line-height: ${({ theme }) => theme.sizeUnit * 9}px; + line-height: 1.5; } .nav-right { display: flex; @@ -91,7 +91,7 @@ const StyledHeader = styled.div<{ backgroundColor?: string }>` .menu > .ant-menu { padding-left: ${({ theme }) => theme.sizeUnit * 5}px; - line-height: ${({ theme }) => theme.sizeUnit * 5}px; + line-height: 1.5; .ant-menu-item { border-radius: ${({ theme }) => theme.borderRadius}px; diff --git a/superset-frontend/src/visualizations/TimeTable/components/SparklineCell/SparklineCell.tsx b/superset-frontend/src/visualizations/TimeTable/components/SparklineCell/SparklineCell.tsx index 4b89c035780d..a4fffac1602a 100644 --- a/superset-frontend/src/visualizations/TimeTable/components/SparklineCell/SparklineCell.tsx +++ b/superset-frontend/src/visualizations/TimeTable/components/SparklineCell/SparklineCell.tsx @@ -231,7 +231,10 @@ const SparklineCell = ({
({ color: theme.colorTextSecondary, - fontSize: '12px', + // Use em so secondary timestamp scales with the + // surrounding cell font-size when users adjust + // browser default text size (WCAG 1.4.4). + fontSize: '0.85em', })} > {formatTime(