From 0000d68c92643d7bb3843ebf60f6228fdd5e16b4 Mon Sep 17 00:00:00 2001 From: Philipp Stephani Date: Thu, 21 Aug 2025 11:46:24 +0200 Subject: [PATCH] Align action mnemonics and progress messages with conventions See the examples in https://bazel.build/rules/lib/builtins/actions#run: - The mnemonic name is usually capitalized. - The progress message is a complete phrase. --- mypy/private/mypy.bzl | 4 ++-- mypy/private/py_type_library.bzl | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/mypy/private/mypy.bzl b/mypy/private/mypy.bzl index b788973..bbe5965 100644 --- a/mypy/private/mypy.bzl +++ b/mypy/private/mypy.bzl @@ -215,8 +215,8 @@ def _mypy_impl(target, ctx): py_type_files = [x for x in ctx.rule.files.data if x.basename == "py.typed" or x.extension == "pyi"] ctx.actions.run( - mnemonic = "mypy", - progress_message = "mypy %{label}", + mnemonic = "Mypy", + progress_message = "Checking Python types for %{label}", inputs = depset( direct = ctx.rule.files.srcs + py_type_files + pyi_files + upstream_caches + config_files, transitive = depsets, diff --git a/mypy/private/py_type_library.bzl b/mypy/private/py_type_library.bzl index b763b97..719659d 100644 --- a/mypy/private/py_type_library.bzl +++ b/mypy/private/py_type_library.bzl @@ -16,6 +16,7 @@ def _py_type_library_impl(ctx): ctx.actions.run( mnemonic = "BuildPyTypeLibrary", + progress_message = "Building Python type library %{output}", inputs = depset(transitive = [ctx.attr.typing.default_runfiles.files]), outputs = [directory], executable = ctx.executable._exec,