From 1a11a3ed16bb2d00e6fe83ec1c2ecf56cfc08f02 Mon Sep 17 00:00:00 2001 From: Mete Cantimur Date: Mon, 22 Dec 2025 11:21:36 +0100 Subject: [PATCH] Migrate from `glog` to `ng-log` library In `bzlmod/01-depend_on_bazel_module`: - Upgrade to Bazel version 8.5.0 - Migrate to `ng-log` logging library --- bzlmod/01-depend_on_bazel_module/.bazelversion | 2 +- bzlmod/01-depend_on_bazel_module/BUILD | 2 +- bzlmod/01-depend_on_bazel_module/MODULE.bazel | 9 +++++---- bzlmod/01-depend_on_bazel_module/README.md | 2 +- bzlmod/01-depend_on_bazel_module/main.cc | 4 ++-- 5 files changed, 10 insertions(+), 9 deletions(-) diff --git a/bzlmod/01-depend_on_bazel_module/.bazelversion b/bzlmod/01-depend_on_bazel_module/.bazelversion index 56b6be4eb..6d2890793 100644 --- a/bzlmod/01-depend_on_bazel_module/.bazelversion +++ b/bzlmod/01-depend_on_bazel_module/.bazelversion @@ -1 +1 @@ -8.3.1 +8.5.0 diff --git a/bzlmod/01-depend_on_bazel_module/BUILD b/bzlmod/01-depend_on_bazel_module/BUILD index 4dd0d2492..902f4be11 100644 --- a/bzlmod/01-depend_on_bazel_module/BUILD +++ b/bzlmod/01-depend_on_bazel_module/BUILD @@ -3,5 +3,5 @@ load("@rules_cc//cc:cc_binary.bzl", "cc_binary") cc_binary( name = "main", srcs = ["main.cc"], - deps = ["@com_github_google_glog//:glog"], + deps = ["@com_github_nglog_nglog//:ng-log"], ) diff --git a/bzlmod/01-depend_on_bazel_module/MODULE.bazel b/bzlmod/01-depend_on_bazel_module/MODULE.bazel index 8dfe33813..8bc85e198 100644 --- a/bzlmod/01-depend_on_bazel_module/MODULE.bazel +++ b/bzlmod/01-depend_on_bazel_module/MODULE.bazel @@ -3,8 +3,9 @@ module( version = "0.0.1", ) -bazel_dep(name = "rules_cc", version = "0.0.17") +bazel_dep(name = "rules_cc", version = "0.1.1") + +# 1. The metadata of ng-log is fetched from the BCR, including its dependencies (gflags). +# 2. The `repo_name` attribute allows users to reference this dependency via the `com_github_nglog_nglog` repo name. +bazel_dep(name = "ng-log", version = "0.8.0-rc1", repo_name = "com_github_nglog_nglog") -# 1. The metadata of glog is fetched from the BCR, including its dependencies (gflags). -# 2. The `repo_name` attribute allows users to reference this dependency via the `com_github_google_glog` repo name. -bazel_dep(name = "glog", version = "0.5.0", repo_name = "com_github_google_glog") diff --git a/bzlmod/01-depend_on_bazel_module/README.md b/bzlmod/01-depend_on_bazel_module/README.md index 57e9174e3..692512c9e 100644 --- a/bzlmod/01-depend_on_bazel_module/README.md +++ b/bzlmod/01-depend_on_bazel_module/README.md @@ -6,5 +6,5 @@ This is an example on how to introduce dependencies on Bazel modules in the MODU To test it out, `cd` into this directory and run the following: ```bash -GLOG_logtostderr=1 bazel run main +NGLOG_logtostderr=1 bazel run main ``` diff --git a/bzlmod/01-depend_on_bazel_module/main.cc b/bzlmod/01-depend_on_bazel_module/main.cc index 33c2a98c4..078393b90 100644 --- a/bzlmod/01-depend_on_bazel_module/main.cc +++ b/bzlmod/01-depend_on_bazel_module/main.cc @@ -1,8 +1,8 @@ -#include +#include int main(int argc, char* argv[]) { // Initialize Google’s logging library. - google::InitGoogleLogging(argv[0]); + nglog::InitializeLogging(argv[0]); int num_cookies = 42; LOG(INFO) << "Found " << num_cookies << " cookies";