Skip to content

feat(scan): add ScanOptionalWidget for handling optional inputs in Sc…#1172

Draft
wakonig wants to merge 2 commits into
mainfrom
feature/optional_input
Draft

feat(scan): add ScanOptionalWidget for handling optional inputs in Sc…#1172
wakonig wants to merge 2 commits into
mainfrom
feature/optional_input

Conversation

@wakonig
Copy link
Copy Markdown
Member

@wakonig wakonig commented May 21, 2026

…anGroupBox

Description

[Provide a brief description of the changes introduced by this pull request.]

Related Issues

[Cite any related issues or feature requests that are addressed or resolved by this pull request. Link the associated issue, for example, with fixes #123 or closes #123.]

Type of Change

  • Change 1
  • Change 2

How to test

  • Run unit tests
  • Open [widget] in designer and play around with the properties

Potential side effects

[Describe any potential side effects or risks of merging this PR.]

Screenshots / GIFs (if applicable)

[Include any relevant screenshots or GIFs to showcase the changes made.]

Additional Comments

[Add any additional comments or information that may be helpful for reviewers.]

Definition of Done

  • Documentation is up-to-date.

@github-actions
Copy link
Copy Markdown
Contributor

Benchmark comparison

Threshold: 20% (lower is better).
Result: 0 regression(s), 0 improvement(s) beyond threshold.

No benchmark regression exceeded the configured threshold.

No benchmark improvement exceeded the configured threshold.

All benchmark results
Benchmark Baseline Current Change Status
BEC IPython client with companion app 6.02327 s 5.93258 s -1.51% ok
BEC IPython client without companion app 1.98514 s 1.91691 s -3.44% ok
Import bec_widgets 0.0137864 s 0.01349 s -2.15% ok
tests/unit_tests/benchmarks/test_dock_area_benchmark.py::test_add_waveform_to_dock_area 0.15188 s 0.153718 s +1.21% ok

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 93.20388% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ets/widgets/control/scan_control/scan_group_box.py 95.60% 1 Missing and 3 partials ⚠️
.../widgets/control/scan_control/scan_info_adapter.py 75.00% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant