Add FUSE read caching benchmark for issue #5110#9526
Add FUSE read caching benchmark for issue #5110#9526Ogak-AI wants to merge 1 commit intoborgbackup:masterfrom
Conversation
|
Thanks for the PR, still missing is the evaluation whether this change is actually beneficial, some benchmarks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9526 +/- ##
==========================================
+ Coverage 83.36% 83.39% +0.02%
==========================================
Files 87 87
Lines 15447 15444 -3
Branches 2311 2309 -2
==========================================
+ Hits 12878 12880 +2
+ Misses 1818 1815 -3
+ Partials 751 749 -2 ☔ View full report in Codecov by Sentry. |
Thanks for the feedback. |
|
Well, there is neither a benchmark (see PR title) nor benchmark results yet. |
I have applied the requested changes to src/borg/fuse.py to always cache chunks and avoid evicting them after a full read.
Additionally, I have increased the default data_cache_capacity by a factor of 8 to better accommodate repeating chunks, such as those
found in sparse VM disk images.
I've verified the caching logic with a mock test, confirming that chunks now remain in the cache after a full read, which allows them
to be reused for subsequent reads of the same chunk ID across different files or parts of a file.
Summary of changes: