diff --git a/.jules/bolt.md b/.jules/bolt.md new file mode 100644 index 0000000..376673d --- /dev/null +++ b/.jules/bolt.md @@ -0,0 +1,3 @@ +## 2024-04-08 - Batch UI updates in ObservableObject +**Learning:** Mutating individual elements of a `@Published` array property (containing structs) inside a loop triggers a UI update notification for every change, causing unnecessary re-renders. +**Action:** Use functional methods like `map` to batch updates into a single array reassignment, significantly reducing UI recalculations. diff --git a/Sources/Cacheout/ViewModels/CacheoutViewModel.swift b/Sources/Cacheout/ViewModels/CacheoutViewModel.swift index 13a9811..ff0251b 100644 --- a/Sources/Cacheout/ViewModels/CacheoutViewModel.swift +++ b/Sources/Cacheout/ViewModels/CacheoutViewModel.swift @@ -172,14 +172,20 @@ class CacheoutViewModel: ObservableObject { } func selectAllSafe() { - for i in scanResults.indices where scanResults[i].category.riskLevel == .safe && !scanResults[i].isEmpty { - scanResults[i].isSelected = true + scanResults = scanResults.map { result in + var newResult = result + if newResult.category.riskLevel == .safe && !newResult.isEmpty { + newResult.isSelected = true + } + return newResult } } func deselectAll() { - for i in scanResults.indices { - scanResults[i].isSelected = false + scanResults = scanResults.map { result in + var newResult = result + newResult.isSelected = false + return newResult } deselectAllNodeModules() } @@ -193,17 +199,29 @@ class CacheoutViewModel: ObservableObject { } func selectStaleNodeModules() { - for i in nodeModulesItems.indices where nodeModulesItems[i].isStale { - nodeModulesItems[i].isSelected = true + nodeModulesItems = nodeModulesItems.map { item in + var newItem = item + if newItem.isStale { + newItem.isSelected = true + } + return newItem } } func selectAllNodeModules() { - for i in nodeModulesItems.indices { nodeModulesItems[i].isSelected = true } + nodeModulesItems = nodeModulesItems.map { item in + var newItem = item + newItem.isSelected = true + return newItem + } } func deselectAllNodeModules() { - for i in nodeModulesItems.indices { nodeModulesItems[i].isSelected = false } + nodeModulesItems = nodeModulesItems.map { item in + var newItem = item + newItem.isSelected = false + return newItem + } } /// Menu bar label: show free GB in the tray