Wallet SDK V1 asserting registry data

[PHOL-DA]

we need to add assertion in certain areas surrounding create commands, case specifically is:

wallet-gateway/sdk/wallet-sdk/src/wallet/namespace/amulet/preapproval.ts

Line 59 in b3ca0b5

expectedDso: amulet.admin,

if amulet.admin is undefined, then a correct command will be created, but without the expectedDSO field, which can even be submitted, but wont work as a valid CC preapproval.

[rukmini-basu-da]

How can you repro this? We get amulet from

const amulet = await fetchAmulet(this.ctx)

which returns an AssetBody and the type is:

type AssetBody = {
    id: string
    displayName: string
    symbol: string
    registryUrl: string
    admin: PartyId
}

So it's unclear how the admin can be undefined

[PHOL-DA]

here is how to reproduce it:
https://github.com/PHOL-DA/wallet-sdk-testing/tree/phol/bug/1797

log output:

[09:10:39.318] WARN (LedgerProvider/2380559): Error in getWithRetry for path /v2/authenticated-user with retry options {"retries":5,"delayMs":3000,"cantonErrorKeys":["SEQUENCER_REQUEST_FAILED","SEQUENCER_BACKPRESSURE","SUBMISSION_ALREADY_IN_FLIGHT","LOCAL_VERDICT_TIMEOUT","NOT_SEQUENCED_TIMEOUT","NO_VIEW_WITH_VALID_RECIPIENTS"]}
    component: "LedgerClient"
[09:10:39.293] INFO (2380559): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTc0NjM5LCJleHAiOjE3NzkxNzgyMzksImlzcyI6InVuc2FmZS1hdXRoIn0.u5ohkp3EHUrpzjZS93idUzuhn7fGz4rbZE0qBxTpJTk
[09:10:39.325] INFO (2380559): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTc0NjM5LCJleHAiOjE3NzkxNzgyMzksImlzcyI6InVuc2FmZS1hdXRoIn0.u5ohkp3EHUrpzjZS93idUzuhn7fGz4rbZE0qBxTpJTk
[09:10:39.335] INFO (2380559): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTc0NjM5LCJleHAiOjE3NzkxNzgyMzksImlzcyI6InVuc2FmZS1hdXRoIn0.u5ohkp3EHUrpzjZS93idUzuhn7fGz4rbZE0qBxTpJTk
[09:10:39.342] INFO (2380559): (SDK)/Generated self-signed JWT token: eyJhbGciOiJIUzI1NiJ9.eyJzdWIiOiJsZWRnZXItYXBpLXVzZXIiLCJhdWQiOiJodHRwczovL2NhbnRvbi5uZXR3b3JrLmdsb2JhbCIsInNjb3BlIjoiIiwiaWF0IjoxNzc5MTc0NjM5LCJleHAiOjE3NzkxNzgyMzksImlzcyI6InVuc2FmZS1hdXRoIn0.u5ohkp3EHUrpzjZS93idUzuhn7fGz4rbZE0qBxTpJTk
[newAddress] partyId is test::12207550c2a8eb182bfc5c520c6ec0696a12d36588190322fa193d2f9b818e7903ae
[newAddress] transferPreApprovalProposal is {
  "CreateCommand": {
    "templateId": "#splice-wallet:Splice.Wallet.TransferPreapproval:TransferPreapprovalProposal",
    "createArguments": {
      "provider": "app_user_localnet-localparty-1::1220e099801f195dead4cd8361a5d8831f08bb447d8359b6efccabe9f32d590a1255",
      "receiver": "test::12207550c2a8eb182bfc5c520c6ec0696a12d36588190322fa193d2f9b818e7903ae"
    }
  }
}
[09:10:42.463] INFO (2380559): (ExternalPartyClient)/Party allocated successfully.
result is {
  "updateId": "1220753d04fc00d4dcab92842f0ff74f757ab5a6867638068a3b31a9f684ec3dbfbf",
  "completionOffset": 72
}

key output is:

[newAddress] transferPreApprovalProposal is {
  "CreateCommand": {
    "templateId": "#splice-wallet:Splice.Wallet.TransferPreapproval:TransferPreapprovalProposal",
    "createArguments": {
      "provider": "app_user_localnet-localparty-1::1220e099801f195dead4cd8361a5d8831f08bb447d8359b6efccabe9f32d590a1255",
      "receiver": "test::12207550c2a8eb182bfc5c520c6ec0696a12d36588190322fa193d2f9b818e7903ae"
    }
  }
}

here there should be a third createArgument expectedDSO