From 9bbf90d568e5fea767cb32431302f6cf71f95f70 Mon Sep 17 00:00:00 2001 From: "Wiessfelt, Katie" Date: Wed, 20 Sep 2023 10:47:26 -0500 Subject: [PATCH 1/4] dynamic request form --- castle/cms/browser/security/requestaccess.py | 1 + .../browser/security/templates/request-form.pt | 17 ++++------------- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/castle/cms/browser/security/requestaccess.py b/castle/cms/browser/security/requestaccess.py index 94e06fde0..4a81f5b91 100644 --- a/castle/cms/browser/security/requestaccess.py +++ b/castle/cms/browser/security/requestaccess.py @@ -51,6 +51,7 @@ def request_access_email_addresses(self): @property def request_access_enabled(self): + import pdb; pdb.set_trace() if api.portal.get_registry_record('plone.request_access_enabled', default=False) is False: return False if len(self.request_access_email_addresses) == 0: diff --git a/castle/cms/browser/security/templates/request-form.pt b/castle/cms/browser/security/templates/request-form.pt index 8cd6cfb46..802262348 100644 --- a/castle/cms/browser/security/templates/request-form.pt +++ b/castle/cms/browser/security/templates/request-form.pt @@ -42,20 +42,11 @@
-
- +
+
- -
-
- -
- -
-
- -
- +
From 56212419535a580901a162c1acb6bb4fce3b0187 Mon Sep 17 00:00:00 2001 From: "Wiessfelt, Katie" Date: Wed, 20 Sep 2023 10:48:01 -0500 Subject: [PATCH 2/4] remove pdb --- castle/cms/browser/security/requestaccess.py | 1 - 1 file changed, 1 deletion(-) diff --git a/castle/cms/browser/security/requestaccess.py b/castle/cms/browser/security/requestaccess.py index 4a81f5b91..94e06fde0 100644 --- a/castle/cms/browser/security/requestaccess.py +++ b/castle/cms/browser/security/requestaccess.py @@ -51,7 +51,6 @@ def request_access_email_addresses(self): @property def request_access_enabled(self): - import pdb; pdb.set_trace() if api.portal.get_registry_record('plone.request_access_enabled', default=False) is False: return False if len(self.request_access_email_addresses) == 0: From 304725dd45a4fce38c1013a094c4b1d0d36fc130 Mon Sep 17 00:00:00 2001 From: "Wiessfelt, Katie" Date: Wed, 20 Sep 2023 18:38:16 -0500 Subject: [PATCH 3/4] cleanup --- castle/cms/browser/security/requestaccess.py | 1 - castle/cms/vocabularies.py | 1 - 2 files changed, 2 deletions(-) diff --git a/castle/cms/browser/security/requestaccess.py b/castle/cms/browser/security/requestaccess.py index 94e06fde0..59f188324 100644 --- a/castle/cms/browser/security/requestaccess.py +++ b/castle/cms/browser/security/requestaccess.py @@ -98,7 +98,6 @@ def request_access(self): logging.error("problem sending request access form", exc_info=True) self.request.response.setStatus(400) - def request_info(self): # we only send data that was requested to actually be sent to prevent exploitation # of the form as much as possible diff --git a/castle/cms/vocabularies.py b/castle/cms/vocabularies.py index 152bb2dd4..c0761c73e 100644 --- a/castle/cms/vocabularies.py +++ b/castle/cms/vocabularies.py @@ -235,7 +235,6 @@ def get_email_template_term_value(self, email_template): }) def __call__(self, context): - # import pdb; pdb.set_trace() catalog = api.portal.get_tool('portal_catalog') email_templates = [ brain.getObject() From 9897535776c89d3f2b99b9e9056602aa6a9906fc Mon Sep 17 00:00:00 2001 From: "Wiessfelt, Katie" Date: Wed, 18 Oct 2023 10:41:56 -0500 Subject: [PATCH 4/4] form url fix --- castle/cms/authentication.py | 3 ++- castle/cms/browser/security/templates/secure-login.pt | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/castle/cms/authentication.py b/castle/cms/authentication.py index 685ed8a9e..e4c8e865d 100644 --- a/castle/cms/authentication.py +++ b/castle/cms/authentication.py @@ -100,7 +100,8 @@ def request_form_url(self): url = '/@@request-form' if not self.is_zope_root and self.registry: url = self.registry.get('plone.request_access_form_path', '/@@request-form') - return url + base_url = api.portal.get().absolute_url() + return ''.join([base_url, url]) @property def expire(self): diff --git a/castle/cms/browser/security/templates/secure-login.pt b/castle/cms/browser/security/templates/secure-login.pt index 2f4195d41..590165dd6 100644 --- a/castle/cms/browser/security/templates/secure-login.pt +++ b/castle/cms/browser/security/templates/secure-login.pt @@ -61,7 +61,12 @@