refactor: use Coder.create() in ArchitectCoder tests

Replace manual __init__ patching with proper Coder.create() factory.
This reduces test maintenance burden by letting the coder initialize
normally instead of manually setting 10+ attributes.

Author: johbo

tests/basic/test_coder.py

@@ -1390,111 +1390,70 @@ async def test_architect_coder_auto_accept_true(self):
             io = InputOutput(yes=True)
             io.confirm_ask = AsyncMock(return_value=False)
 
-            with patch("aider.coders.architect_coder.AskCoder.__init__", return_value=None):
-                from aider.coders.architect_coder import ArchitectCoder
-
-                coder = ArchitectCoder()
-                coder.io = io
-                coder.main_model = self.GPT35
-                coder.args = MagicMock(tweak_responses=False)
-                coder.auto_accept_architect = True
-                coder.verbose = False
-                coder.total_cost = 0
-                coder.cur_messages = []
-                coder.done_messages = []
-                coder.aider_commit_hashes = []
-                coder.summarizer = MagicMock()
-                coder.summarizer.too_big.return_value = False
-
-                mock_editor = MagicMock()
-                mock_editor.generate = AsyncMock()
-                mock_editor.total_cost = 0
-                mock_editor.aider_commit_hashes = []
-                with patch(
-                    "aider.coders.architect_coder.Coder.create",
-                    new_callable=AsyncMock,
-                    return_value=mock_editor,
-                ):
-                    coder.partial_response_content = "Make these changes to the code"
-
-                    with pytest.raises(SwitchCoder):
-                        await coder.reply_completed()
-
-                    io.confirm_ask.assert_called_once_with(
-                        "Edit the files?", allow_tweak=False
-                    )
-                    mock_editor.generate.assert_called_once()
+            coder = await Coder.create(self.GPT35, edit_format="architect", io=io)
+            coder.auto_accept_architect = True
+            coder.partial_response_content = "Make these changes to the code"
+
+            mock_editor = MagicMock()
+            mock_editor.generate = AsyncMock()
+            mock_editor.total_cost = 0
+            mock_editor.aider_commit_hashes = []
+
+            with patch(
+                "aider.coders.architect_coder.Coder.create",
+                new_callable=AsyncMock,
+                return_value=mock_editor,
+            ):
+                with pytest.raises(SwitchCoder):
+                    await coder.reply_completed()
+
+                io.confirm_ask.assert_called_once_with("Edit the files?", allow_tweak=False)
+                mock_editor.generate.assert_called_once()
 
     async def test_architect_coder_auto_accept_false_confirmed(self):
         with GitTemporaryDirectory():
             io = InputOutput(yes=False)
             io.confirm_ask = AsyncMock(return_value=True)
 
-            with patch("aider.coders.architect_coder.AskCoder.__init__", return_value=None):
-                from aider.coders.architect_coder import ArchitectCoder
-
-                coder = ArchitectCoder()
-                coder.io = io
-                coder.main_model = self.GPT35
-                coder.args = MagicMock(tweak_responses=False)
-                coder.auto_accept_architect = False
-                coder.verbose = False
-                coder.total_cost = 0
-                coder.cur_messages = []
-                coder.done_messages = []
-                coder.aider_commit_hashes = []
-                coder.summarizer = MagicMock()
-                coder.summarizer.too_big.return_value = False
-
-                mock_editor = MagicMock()
-                mock_editor.generate = AsyncMock()
-                mock_editor.total_cost = 0
-                mock_editor.aider_commit_hashes = []
-                with patch(
-                    "aider.coders.architect_coder.Coder.create",
-                    new_callable=AsyncMock,
-                    return_value=mock_editor,
-                ):
-                    coder.partial_response_content = "Make these changes to the code"
-
-                    with pytest.raises(SwitchCoder):
-                        await coder.reply_completed()
-
-                    io.confirm_ask.assert_called_once_with(
-                        "Edit the files?", allow_tweak=False
-                    )
-                    mock_editor.generate.assert_called_once()
+            coder = await Coder.create(self.GPT35, edit_format="architect", io=io)
+            coder.auto_accept_architect = False
+            coder.partial_response_content = "Make these changes to the code"
+
+            mock_editor = MagicMock()
+            mock_editor.generate = AsyncMock()
+            mock_editor.total_cost = 0
+            mock_editor.aider_commit_hashes = []
+
+            with patch(
+                "aider.coders.architect_coder.Coder.create",
+                new_callable=AsyncMock,
+                return_value=mock_editor,
+            ):
+                with pytest.raises(SwitchCoder):
+                    await coder.reply_completed()
+
+                io.confirm_ask.assert_called_once_with("Edit the files?", allow_tweak=False)
+                mock_editor.generate.assert_called_once()
 
     async def test_architect_coder_auto_accept_false_rejected(self):
         with GitTemporaryDirectory():
             io = InputOutput(yes=False)
             io.confirm_ask = AsyncMock(return_value=False)
 
-            with patch("aider.coders.architect_coder.AskCoder.__init__", return_value=None):
-                from aider.coders.architect_coder import ArchitectCoder
-
-                coder = ArchitectCoder()
-                coder.io = io
-                coder.main_model = self.GPT35
-                coder.args = MagicMock(tweak_responses=False)
-                coder.auto_accept_architect = False
-                coder.verbose = False
-                coder.total_cost = 0
-
-                mock_create = AsyncMock()
-                with patch(
-                    "aider.coders.architect_coder.Coder.create",
-                    mock_create,
-                ):
-                    coder.partial_response_content = "Make these changes to the code"
-
-                    result = await coder.reply_completed()
-
-                    assert result is None
-                    io.confirm_ask.assert_called_once_with(
-                        "Edit the files?", allow_tweak=False
-                    )
-                    mock_create.assert_not_called()
+            coder = await Coder.create(self.GPT35, edit_format="architect", io=io)
+            coder.auto_accept_architect = False
+            coder.partial_response_content = "Make these changes to the code"
+
+            mock_create = AsyncMock()
+            with patch(
+                "aider.coders.architect_coder.Coder.create",
+                mock_create,
+            ):
+                result = await coder.reply_completed()
+
+                assert result is None
+                io.confirm_ask.assert_called_once_with("Edit the files?", allow_tweak=False)
+                mock_create.assert_not_called()
 
     @patch("aider.coders.base_coder.experimental_mcp_client")
     async def test_mcp_server_connection(self, mock_mcp_client):