"Fix": test_20x20 strip for line comparison#138
Merged
Conversation
Trim trailing commas in comparison for test validation.
DLWoodruff
approved these changes
May 14, 2026
DLWoodruff
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #137
Not really a "fix" as the test was passing as is. This change hedges against trailing commas.
Both baseline CSVs were updated in #75 (Dec 2020) to include trailing commas. However, the
test_20x20baseline data was later updated again in commit 60111bf (Apr 2021) which eliminated the trailing commas. This is where the inconsistency arose.