Missingness and API Calls

[coatless]

Consider:

repo_transfer = function(owner, repo, new_owner, team_id = NA) {
  if( is.na(team_id) ) {
    gh("POST /repos/:owner/:repo/transfer",
       owner = owner,
       repo = repo,
       new_owner = new_owner)
  } else {
    gh("POST /repos/:owner/:repo/transfer",
       owner = owner,
       repo = repo,
       new_owner = new_owner,
       team_id = team_id)
  }
}

There is a lot of code duplication.

Perhaps a variant of do.call with the parameters being added into a list() is better suited to this endeavor. Unless, there is something I'm overlooking in terms of evoking gh.

[lwjohnst86]

I created a similar package (githubr) mostly targeted to making and editing issues. I dealt with that here:

add_request_parameters <- function(...) {
    params <- list(...)
    Filter(Negate(is.null), params)
}

And I had each param's default being NULL. So then all NULL params are dropped, so that I could then pass the params to:

do.call(gh::gh, params)

[coatless]

@lwjohnst86 thanks for the comment. This looks like what I was proposing in r-lib/gh#84.